-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smdbltrp #1722
Add Smdbltrp #1722
Conversation
This PR has a encoding.h change which is not merged upstream in riscv-opcodes yet. I will refresh it once the riscv-opcodes PR riscv/riscv-opcodes#257 gets merged. |
I merged the riscv-opcodes PR using a merge commit. The SHA hash is still valid, so there is no need to refresh encoding.h. Please squash the two commits into a single commit, though. I’ll perform a code review next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about this one too deeply, but it looks good to me based on a cursory review. Thanks!
@ved-rivos please fix the new conflicts and rebase/squash, then ping me to merge it. |
@aswaterman thanks. The conflicts have been resolved. |
@aswaterman - ptal if further changes are needed. |
@ved-rivos thanks for the ping; I must've missed your previous message. |
Spec: https://github.com/riscv/riscv-double-trap
Tests: riscv-non-isa/riscv-arch-test#438