Update mcontrol6 to support version 1.0 #1667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of updating the mcontrol6 version, where these details matter.
Just to keep things cleaner.
The new semantics are that the hardware gets to decide what the timing is, and the debugger has no input on it. This implements that, but still using the old bit encodings. That's still valid since all trigger registers are WARL.
Functionally this means tinfo is updated to bump the version, and mcontrol6 loses the timing bit and now has hit0 and hit1 bits to describe in detail when a trigger was hit. This requires a new debug_defines, generated by the debug spec.
|
This isn't ready for spike maintainer review yet, but I want it to be public so I can run it by someone else. |
13 tasks
|
Sorry for this. There is an approved but not merged PR for mcontrol6.hit0/hit1. |
|
@YenHaoChen, looks like spike doesn't implement tcontrol mte/mpte. Are you interested in implementing that or should I do it? |
|
I created a PR for the tcontrol. (#1688) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionally this means tinfo is updated to bump the version, and mcontrol6 loses the timing bit and now has hit0 and hit1 bits to describe in detail when a trigger was hit.