Add support for smstateen 1.0.0

[liweiwei90]

Add support for smstateen 1.0.0:

• remove multi blink lines in riscv/
• add support for smstateen related CSRs
• add smstateen check for fcsr, s/henvcfg

[scottj97]

encoding.h is generated by riscv-opcodes package; it should not be hand-edited.

If this was indeed generated from riscv-opcodes please record which commit hash in the commit message here.

[liweiwei90]

encoding.h is generated by riscv-opcodes package; it should not be hand-edited.

If this was indeed generated from riscv-opcodes please record which commit hash in the commit message here.

OK, I have sent a PR(riscv/riscv-opcodes#134) to riscv-opcodes to support this.

[scottj97]

In the first commit, s/blink/blank/

[scottj97]

It would be best to get that riscv-opcodes change merged first, just in case it needs rebasing and the commit hash changes (in which case the hash here in encoding.h would be stale).

[aswaterman]

I've merged the corresponding riscv-opcodes PR.

[liweiwei90]

I've merged the corresponding riscv-opcodes PR.

Ok. Thanks a lot, I'll update the encoding.h.

[scottj97]

I have tested this only so far as to see that it doesn't break any other features. I have not tested the Smstateen functionality.

@liweiwei90 can you tell us how you have tested this code?

[liweiwei90]

I have tested this only so far as to see that it doesn't break any other features. I have not tested the Smstateen functionality.

@liweiwei90 can you tell us how you have tested this code?

Sorry. I didn't test the code systematically. Partial of the code was tested in an ugly way, such as for the check for fcsr, I set the bit in mstateen/sstateen to different values in reset to test the access from U mode. All of the functions are privilege-related. I didn't know a good way to test them. Any suggestions?

[scottj97]

Sorry. I didn't test the code systematically. Partial of the code was tested in an ugly way, such as for the check for fcsr, I set the bit in mstateen/sstateen to different values in reset to test the access from U mode. All of the functions are privilege-related. I didn't know a good way to test them. Any suggestions?

All of these features need architectural tests, which are out of scope for Spike contributors, but such tests are sorely lacking in the open-source world. :(

[scottj97]

All good now. Thank you for the contribution and for your patience with the review process.

[aswaterman]

🎉