Skip to content

Commit

Permalink
pointer masking: Consider effective v bit instead of current v bit
Browse files Browse the repository at this point in the history
A previous commit removes the effectiveness of MPRV to MXR.
(#1784)

However, the removal implies the MPRV affects point masking
individually, and the MXR should consider the effective v bit.
  • Loading branch information
YenHaoChen committed Aug 28, 2024
1 parent 5029aa7 commit 61d277c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion riscv/mmu.cc
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ void mmu_t::register_memtracer(memtracer_t* t)
}

reg_t mmu_t::get_pmlen(bool effective_virt, reg_t effective_priv, xlate_flags_t flags) const {
if (!proc || proc->get_xlen() != 64 || (proc->state.sstatus->read() & MSTATUS_MXR) || flags.hlvx)
if (!proc || proc->get_xlen() != 64 || (proc->state.sstatus->readvirt(effective_virt) & MSTATUS_MXR) || flags.hlvx)
return 0;

reg_t pmm = 0;
Expand Down

0 comments on commit 61d277c

Please sign in to comment.