Sunil's feedback on allowing RSCV IDs to be used as either HID or CID. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsunil
reviewed
Jun 7, 2024
acpi.adoc
Outdated
| @@ -33,7 +33,7 @@ available to an OS loader via the standard `UEFI EFI_GRAPHICS_OUTPUT_PROTOCOL` i | |||
| * Revision 4 or later of SPCR. | |||
| * For NS16550-compatible UARTs: | |||
| ** Use `Interface Type` 0x12 (16550-compatible with parameters defined in Generic Address Structure). | |||
| ** There MUST be a matching AML device object with compatible ID `RSCV0003`. | |||
| ** There MUST be a matching AML device object with `_HID` (Hardware ID) or `_CID` (Compatibility ID) `RSCV0003`. | |||
There was a problem hiding this comment.
Thanks for adding HID as well. ACPI spec (6.1.2) refers as Compatible ID itself. So, better to have "Compatible ID" instead of "Compatibility ID" ?
non-normative/acpi.adoc
Outdated
| @@ -150,7 +150,7 @@ and <<acpi-irq-gsb, `AML_090`>> requirements. | |||
|
|
|||
| On some architectures, it became an industry accepted norm to describe PCIe implementations not compliant to the _PCI Firmware Specification_ cite:[PCIFW] | |||
| using specification-defined ACPI tables and objects. RISC-V systems compliant to the BRS must only expose ECAM-compatible implementations using the | |||
| MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatible ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior. | |||
| MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatibility ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior. | |||
There was a problem hiding this comment.
IMO, this change is not required.
Signed-off-by: Andrei Warkentin <[email protected]>
vlsunil
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.