Skip to content

Commit

Permalink
Sunil's feedback on allowing RSCV IDs to be used as either HID or CID.
Browse files Browse the repository at this point in the history
Signed-off-by: Andrei Warkentin <[email protected]>
  • Loading branch information
Andrei Warkentin committed Jun 3, 2024
1 parent 4da6020 commit 3ea4122
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion acpi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ available to an OS loader via the standard `UEFI EFI_GRAPHICS_OUTPUT_PROTOCOL` i
* Revision 4 or later of SPCR.
* For NS16550-compatible UARTs:
** Use `Interface Type` 0x12 (16550-compatible with parameters defined in Generic Address Structure).
** There MUST be a matching AML device object with compatible ID `RSCV0003`.
** There MUST be a matching AML device object with `_HID` (Hardware ID) or `_CID` (Compatibility ID) `RSCV0003`.
2+| _See <<acpi-guidance-spcr, additional guidance>>_.
| [[acpi-namespace-dev]]`ACPI_080` | PLIC/APLIC namespace devices MUST
be present in the ACPI namespace whenever corresponding MADT entries are
Expand Down
2 changes: 1 addition & 1 deletion non-normative/acpi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ and <<acpi-irq-gsb, `AML_090`>> requirements.

On some architectures, it became an industry accepted norm to describe PCIe implementations not compliant to the _PCI Firmware Specification_ cite:[PCIFW]
using specification-defined ACPI tables and objects. RISC-V systems compliant to the BRS must only expose ECAM-compatible implementations using the
MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatible ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior.
MCFG and the standard AML Hardware ID (`_HID`) `PNP0A08` and Compatibility ID (`_CID`) `PNP0A03`, and must not rely on ACPI table header information or other out-of-band means of detecting quirked behavior.

Some minor incompatibilities, such as incorrect CFG0 filtering, broken BARs/capabilities for RCs, embedded switches/bridges
or embedded endpoints can be handled by emulating ECAM accesses in privileged firmware (e.g. M-mode) or similar facilities (e.g. a hypervisor).
Expand Down

0 comments on commit 3ea4122

Please sign in to comment.