Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dimension values with null measure values in dimension table are not shown when filter by that measures #6255

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: dimension values with null measure values in dimension table are not shown when filter by that measures #6255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions web-common/src/features/dashboards/dimension-table/dimension-table-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ export function prepareVirtualizedDimTableColumns(
.filter((column) => column !== undefined);

// cast is safe, because we filtered out undefined columns
return (columns as VirtualizedTableColumns[]) ?? [];
return columns ?? [];
}

/**
Expand Down Expand Up @@ -426,10 +426,7 @@ export function prepareDimensionTableRows(
);

const tableRows: DimensionTableRow[] = queryRows
.filter(
(row) =>
row[activeMeasureName] !== undefined && row[activeMeasureName] !== null,
)
.filter((row) => row[activeMeasureName] !== undefined)
.map((row) => {
const measureValue = row[activeMeasureName];

Expand Down
Loading