Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dimension values with null measure values in dimension table are not shown when filter by that measures #6255

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: dimension values with null measure values in dimension table are not shown when filter by that measures #6255

merged 1 commit into from
Dec 13, 2024

Conversation

AdityaHegde
Copy link
Collaborator

No description provided.

@AdityaHegde AdityaHegde self-assigned this Dec 11, 2024
@djbarnwal
Copy link
Member

As discussed, the sorted values show NULL values at top when sorting in descending order.
https://www.notion.so/rilldata/Bug-Bash-Dec-2024-159ba33c8f578027970beb993567142f?pvs=4#159ba33c8f5780549f6dc4f34a4636dc

@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Dec 13, 2024 •
edited
Loading

@djbarnwal lets take that separately. The fix will be quite independent

@djbarnwal djbarnwal merged commit 1fc965b into main Dec 13, 2024
9 checks passed
@djbarnwal djbarnwal deleted the fix/dimension-table-null-values branch December 13, 2024 09:02
AdityaHegde added a commit that referenced this pull request Dec 16, 2024
@AdityaHegde
Do not filter null measure values in dimension table (#6255)
950f847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbarnwal djbarnwal djbarnwal approved these changes

Assignees

@AdityaHegde AdityaHegde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @djbarnwal