Cloud UI: Surface Custom Dashboards in navigation #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
3 tasks
briangregoryholmes
approved these changes
Apr 16, 2024
AdityaHegde
pushed a commit
that referenced
this pull request
Apr 17, 2024
* WIP commit * Fix lint * Use TanStack Query client to fetch chart data * TODO: render a "read-only" version of the dashboard * Utils to differentiate between Metrics Explorer and Custom Dashboard pages * Show both Metrics Explorers and Custom Dashboards in the breadcrumb * Remove console log * Add wrongly-detected TS error to whitelist * Small clean-up * Fix merge * Remove unused component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
{org}/{project}/-/dashboards/{custom-dashboard}This PR does not actually render a Custom Dashboard, but rather renders a placeholder. We'll need a "read-only", non-editable Custom Dashboard component. This should be taken in a separate PR.
Closes #4314