File explorer follow ups fixes #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdityaHegde
commented
Apr 16, 2024
•
AdityaHegde
commented
- Fix renaming of a folder
- Fix charts and custom-dashbaords
- Fix editor losing focus when entity errors out
ericpgreen2
approved these changes
Apr 16, 2024
| @@ -13,6 +13,7 @@ export const resourceIconMapping = { | |||
| [ResourceKind.MetricsView]: DashboardIcon, | |||
| [ResourceKind.API]: ApiIcon, | |||
| [ResourceKind.Chart]: Chart, | |||
| [ResourceKind.Dashboard]: DashboardIcon, // TODO: show this be different? | |||
There was a problem hiding this comment.
Yes, custom dashboards should use the bottom icon here:
There was a problem hiding this comment.
Will update once #4531 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.