Reconcile merge conflicts for #85 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Sauthier <[email protected]>
…tflag Removing the short flag from kubectl
Uninstall for v1.20 or higher
… character. Small refactor.
|
Thanks! I didn't even realize that there was a new release and this wasn't clean to merge anymore. In general it looks good, I'll double check everything tomorrow. The only thing I might change would be to separate the podman support to a separate PR to the main repo. It looks like a straightforward change, but will make things cleaner. |
|
I included the Podman thing as a separate commit for that reason, feel free to revert / nix it. 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reconciles the merge pending merge conflicts to address SynologyOpenSource#85 and SynologyOpenSource#89.
Also includes a drive-by to add support for building with Podman.