Predefined tool paths #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool executor is capable of running given tools in chroot either by automatically locating the tools in path using the `env` command or directly if the path is known. This removes the need for the shell script to wrap commands and reduces number of needed external binaries on the node.
Instead of checking the existence of chroot target directory runtime, only enable chroot on the node daemon. This way the service will fail early if the chroot doesn't exist, instead of printing an error during runtime.
|
Fantastic! Thanks @ressu! I tested this on my Synology DS923+ and it works! I want to add that you need the Talos iscsi-tools extension on talos to run the fork: https://github.com/siderolabs/extensions/pkgs/container/iscsi-tools#storage Additionally I had to modify synology-csi-node daemon set to add the following args to the csi-plugin container: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using minimalistic Kubernetes deployments, like Talos, the
/usr/bin/envcommand isn't available. Instead of always relying on env, replace the chroot shell wrapper with a tool that can either invoke chroot with the env command or directly using a full path of the tool.The change adds a new flag to define the location of chroot and the relevant tools. The node service now also check for existence of the chroot directory at the beginning of startup to warn about misconfiguration.