Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations discrepancies #3219

Merged

Conversation

pdcp1
Copy link
Collaborator

@pdcp1 pdcp1 commented Nov 14, 2024

This PR addresses all discrepancies in translations and resolves any missing translations found in https://incidentdatabase.ai/meta/i18n

Preview link

https://pr-3219--staging-aiid.netlify.app/meta/i18n

Result

image

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (ef1846d) to head (ca525a5).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #3219   +/-   ##
========================================
  Coverage    97.17%   97.17%           
========================================
  Files           60       60           
  Lines        12334    12334           
  Branches       308      308           
========================================
  Hits         11986    11986           
  Misses         334      334           
  Partials        14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdcp1 pdcp1 marked this pull request as ready for review November 14, 2024 17:36
@pdcp1 pdcp1 requested a review from clari182 November 14, 2024 17:36
@pdcp1
Copy link
Collaborator Author

pdcp1 commented Nov 14, 2024

Hi @technohippy,

Since you were the one who initially added the first Japanese translations to the system, could you please take a look at the changes in the JA folder https://github.com/responsible-ai-collaborative/aiid/pull/3219/files? We would really appreciate your feedback on whether those translations make sense to you. Thank you!

Copy link
Collaborator

@clari182 clari182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Waiting on @technohippy review of ja to merge.

# Conflicts:
#	site/gatsby-site/i18n/locales/es/submit.json
#	site/gatsby-site/i18n/locales/fr/entities.json
#	site/gatsby-site/i18n/locales/fr/submit.json
#	site/gatsby-site/i18n/locales/fr/validation.json
#	site/gatsby-site/i18n/locales/ja/submit.json
#	site/gatsby-site/i18n/locales/ja/validation.json
@pdcp1 pdcp1 merged commit efaa05b into responsible-ai-collaborative:staging Dec 20, 2024
22 checks passed
@pdcp1 pdcp1 deleted the fix/add-missing-translations branch December 20, 2024 17:08
@pdcp1 pdcp1 mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants