-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translations discrepancies #3219
Fix translations discrepancies #3219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3219 +/- ##
========================================
Coverage 97.17% 97.17%
========================================
Files 60 60
Lines 12334 12334
Branches 308 308
========================================
Hits 11986 11986
Misses 334 334
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Hi @technohippy, Since you were the one who initially added the first Japanese translations to the system, could you please take a look at the changes in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Waiting on @technohippy review of ja
to merge.
# Conflicts: # site/gatsby-site/i18n/locales/es/submit.json # site/gatsby-site/i18n/locales/fr/entities.json # site/gatsby-site/i18n/locales/fr/submit.json # site/gatsby-site/i18n/locales/fr/validation.json # site/gatsby-site/i18n/locales/ja/submit.json # site/gatsby-site/i18n/locales/ja/validation.json
This PR addresses all discrepancies in translations and resolves any missing translations found in https://incidentdatabase.ai/meta/i18n
Preview link
https://pr-3219--staging-aiid.netlify.app/meta/i18n
Result