Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: account for etcd leader changes error #5003

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix test when failing to fetch secret
we now return a 500 error when we aren't able to load the secret to
validate if the password has changed since the session was created.
ricardomaraschini committed Nov 20, 2024

Verified

This commit was signed with the committer’s verified signature.
ricardomaraschini Ricardo Maraschini
commit 4d170544f4fdeda9d5d125be8cba0f52a0d26749
2 changes: 1 addition & 1 deletion pkg/handlers/session_test.go
Original file line number Diff line number Diff line change
@@ -400,7 +400,7 @@ func Test_requireValidSession_FailedToFetchPasswordUpdated_AfterSessionIssuedErr
req.Error(err)
req.Equal("failed to fetch password updatedAt", err.Error())
req.Equal(want, got)
req.Equal(401, w.Code)
req.Equal(500, w.Code)
}

func Test_requireValidSession_PasswordUpdated_AfterSessionIssuedErr(t *testing.T) {

Unchanged files with check annotations Beta

return (
<div className="flex-column flex1 container">
<KotsPageTitle pageName="Preflight Checks" showAppSlug />
{Utilities.isInitialAppInstall(selectedApp) && props.isEmbeddedCluster && (

Check warning on line 82 in web/src/components/PreflightResultPage.tsx

GitHub Actions / lint-web

This line has a length of 81. Maximum allowed is 80
<div className="tw-mt-8 tw-shadow-[0_1px_0_#c4c8ca]">
<p className="tls-header tw-pb-8 tw-font-bold u-textColor--primary">
Validate the environment & deploy {selectedApp?.name}
className="btn primary blue"
disabled={preflightCheck?.showDeploymentBlocked}
onClick={() =>
preflightCheck?.shouldShowConfirmContinueWithFailedPreflights

Check warning on line 224 in web/src/components/PreflightResultPage.tsx

GitHub Actions / lint-web

This line has a length of 85. Maximum allowed is 80
? setShowContinueWithFailedPreflightsModal(true)
: deployKotsDownstream({
continueWithFailedPreflights: true,
{generateAddNodeCommandError?.message}
</p>
)}
{!generateAddNodeCommandLoading && generateAddNodeCommand?.command && (

Check warning on line 507 in web/src/components/apps/EmbeddedClusterManagement.tsx

GitHub Actions / lint-web

This line has a length of 81. Maximum allowed is 80
<>
<CodeSnippet
key={selectedNodeTypes.toString()}