bug: account for etcd leader changes error #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-97671/admin-console-makes-you-log-in-again-after
branch
3 times, most recently
from
4061607 to
d706447
Compare
sgalsaleh
previously approved these changes
Nov 13, 2024
sgalsaleh
previously approved these changes
Nov 15, 2024
if we fail to read the secret from etcd we should return an internal server error and not an unauthorized error.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-97671/admin-console-makes-you-log-in-again-after
branch
from
54ef8ef to
c9e8915
Compare
we now return a 500 error when we aren't able to load the secret to validate if the password has changed since the session was created.
…es-you-log-in-again-after
sgalsaleh
approved these changes
Nov 20, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-97671/admin-console-makes-you-log-in-again-after
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
if we fail to read the secret from etcd we should return an internal server error and not an unauthorized error. this pr also adds a missing log.
Which issue(s) this PR fixes:
shortcut story
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE