Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable rolling back the app on embedded cluster #4493

Merged
merged 1 commit into from
Mar 6, 2024
Merged

disable rolling back the app on embedded cluster #4493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/store/kotsstore/version_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ func (s *KOTSStore) IsRollbackSupportedForVersion(appID string, sequence int64)
return false, errors.Wrap(err, "failed to load kots app from contents")
}

if util.IsEmbeddedCluster() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not at the very beginning of the function? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, "because that might impact behavior more than where it is now"

maybe moving it to the beginning means that 'can't get app' errors are surfaced differently

return false, nil
}

return kotsAppSpec.Spec.AllowRollback, nil
}

Expand Down
Loading