disable rolling back the app on embedded cluster #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalsaleh
reviewed
Mar 5, 2024
| @@ -71,6 +71,10 @@ func (s *KOTSStore) IsRollbackSupportedForVersion(appID string, sequence int64) | |||
| return false, errors.Wrap(err, "failed to load kots app from contents") | |||
| } | |||
|
|
|||
| if util.IsEmbeddedCluster() { | |||
There was a problem hiding this comment.
why not at the very beginning of the function? :)
There was a problem hiding this comment.
actually, "because that might impact behavior more than where it is now"
maybe moving it to the beginning means that 'can't get app' errors are surfaced differently
|
I'll leave the code review to those more familiar, but the concept of disabling this for Embedded Cluster 👍 |
sgalsaleh
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?