-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a node-compatible export #12
Open
gkjohnson
wants to merge
6
commits into
repalash:master
Choose a base branch
from
gkjohnson:node-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6366878
Add a separate node build
gkjohnson 1f33916
Automatically load the library with node worker
gkjohnson d117529
Remove unused file
gkjohnson 1087c20
add xatlasjs dependency
gkjohnson 6766f72
Remove logs
gkjohnson 39f881d
Move library await to base unwrapper
gkjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import {Atlas, BaseUVUnwrapper} from "./UVUnwrapper"; | ||
import {XAtlasNodeWorker} from "./XAtlasNodeWorker"; | ||
import {createRequire} from "node:module"; | ||
import path from "node:path"; | ||
|
||
export class UVUnwrapper extends BaseUVUnwrapper{ | ||
protected _createXAtlas(): any { | ||
return new XAtlasNodeWorker() | ||
} | ||
|
||
constructor(...args:any[]) { | ||
super(...args); | ||
|
||
// https://stackoverflow.com/questions/54977743/do-require-resolve-for-es-modules | ||
const require = createRequire(import.meta.url); | ||
const pathName = path.dirname(require.resolve('xatlasjs/package.json')); | ||
|
||
// Make sure to wait for the library to load before unwrapping. | ||
this.loadLibrary( | ||
(mode, progress)=>{}, | ||
`${pathName}/dist/node/xatlas.wasm`, | ||
`${pathName}/dist/node/worker.mjs`, | ||
); | ||
} | ||
|
||
exit(): Promise<void> { | ||
return this.xAtlas?.api.exit(); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript seems to not like this spread syntax for passing through the arguments to the parent constructor. I looked it up but there didn't seem to be a clear solution. Do we have to reproduce all the arguments and types for this constructor?