-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a node-compatible export #12
base: master
Are you sure you want to change the base?
Conversation
constructor(...args:any[]) { | ||
super(...args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript seems to not like this spread syntax for passing through the arguments to the parent constructor. I looked it up but there didn't seem to be a clear solution. Do we have to reproduce all the arguments and types for this constructor?
I'm also seeing this warning when running the node instance - looks like there's maybe a memory leak in xatlasjs? Or "comlink"?
|
Fix #9
node.ts
file.node
entry to the webpack build so two entry points are built (one for browser, one for node)xatlas-three/node
so the node variant can be used easily.Once node is working correctly there are a few things I'd like to adjust in future PRs if that's okay - let me know how this sounds:
BufferAttribute
to the constructor.