Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject: unpin some minor versions #43

Merged
merged 1 commit into from
Oct 12, 2023
Merged

pyproject: unpin some minor versions #43

merged 1 commit into from
Oct 12, 2023

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Oct 11, 2023

to assist with compatability since nxontontology-data now depends this package.

to assist with compatability since nxontontology-data now depends
this package.
jupyter = "^1.0.0"
nbconvert = "^6.2.0"
notebook = "^6.4.4"
bioregistry = "^0.10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.10 needed for pydantic 1 and 2 support

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my assistant:

  1. bioregistry = "^0.10.0": This will pin the dependency to the latest 0.10.x version that is available. So it could install 0.10.0, 0.10.1, 0.10.2, etc., but it would not install 0.11.0 or higher.

  2. bioregistry = "^0.10": This is more permissive and will pin the dependency to the latest 0.x version that is available, starting from 0.10. So this could install 0.10.0, 0.11.0, 0.12.0, etc., but it would not install 1.0.0 or higher.

Since we're now importing this library elsewhere, I think it makes sense to only pin the major version to allow greater compatibility. The poetry.lock always allows us to know which past version worked if something breaks.

I didn't relax everything, just those that are likely to be used by nxontology-data or its dependencies.

@dhimmel dhimmel requested a review from yonromai October 11, 2023 18:56
Copy link
Contributor

@yonromai yonromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@dhimmel dhimmel merged commit 5b8e8ed into main Oct 12, 2023
2 checks passed
@dhimmel dhimmel deleted the dsh-relax-deps branch October 12, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants