Use atomic commits for DRM rendering #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use atomic commits for DRM rendering, and also add support for using pure python kms module if available, instead of current C++ bindings Signed-off-by: William Vinnicombe <[email protected]>
|
@will-v-pi Thanks for this! LGTM. Are you happy to go ahead and merge? It seems a bit annoying that we have to invoke the garbage collector explicitly, this does seem to be a bit of a sore point with Python sometimes. |
|
Yeah, I'm happy to merge - with the garbage collection, I added that as the card only seems to get garbage collected once a new preview is started rather than when a preview is stopped, which was causing issues in the drm stop restart test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use atomic commits for DRM rendering, and also add support for using pure python kms module if available, instead of current C++ bindings