Enable atomic commits for DRM rendering #764
Conversation
Signed-off: Peyton Howe <[email protected]>
|
Hi, thanks for this PR. Is is really just using One thing I wonder about is whether the code should be reorganised a bit so that the image and overlay are added to the same atomic commit? Presumably that's where the benefit would be, in that we'd only be waiting for one vsync for both as opposed to two. What do you think? |
Signed-off-by: Peyton Howe <[email protected]>
… commit If the overlay and camera frame are in different atomic commits, then the overlay tends to update at a faster refresh rate, causing the camera feed to 'lag' behind. However, at lower camera framerates, the camera feed renders at the desired framerate, while the overlay updates faster. To remedy the conflicting refresh rates, make sure to only render the overlay with an accompanying camera frame. Signed-off-by: Peyton Howe <[email protected]>
|
I was surprised that Using the same atomic commit for the image and the overlay is definitely the way to go, otherwise the overlay will update at a faster refresh rate than the camera feed. |
|
We're proposing to replace this PR by #925, which should do the same thing. |
|
Closing this as we've merged the "revised version". Hope that's all good! |
Signed-off: Peyton Howe [email protected]