Lidar performance #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y not being used as it does not seem to work as intended
Tadinu
reviewed
Oct 18, 2021
Comment on lines
+235
to
+236
| // this can be maybe parallelized? a first trial with ParallelFor crashes - need to verify that LineBatchComponent is thread-safe | ||
| for (int i=0; i<RecordedHits.Num(); i++) |
There was a problem hiding this comment.
Probably the drawing itself must run in game thread, if in which case we could put LineBatcher->DrawPoint() to an async?
There was a problem hiding this comment.
I haven't really investigated and is possibly low priority because in production mode we don't need to draw anyway
the current multipass approach can also be moved to async btw
Tadinu
approved these changes
Oct 18, 2021
tetorea
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of Lidar3d with sampling spread over time to load balance
while it does improve performance and make everything smoother, it is probably not sufficient for multiple 3d lidars in the scene.
not drawing lidar points does help as well
also need to test in production/packaged mode
The 'alpha' parts of the code are made for visualization, but they don't currently work as intended.
The intent was to have lidar hits fade away with time so that it's clearer where it is currently being scanned