Allow mountPropagation configuration by merging the helper Pod template's volumeMount #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
make_mount_propagation_configurable
branch
9 times, most recently
from
67744ad to
b4d21da
Compare
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
make_mount_propagation_configurable
branch
from
b4d21da to
e4bc223
Compare
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
make_mount_propagation_configurable
branch
from
e4bc223 to
7049c8e
Compare
|
hm, the e2e test I ll look into it some other day... |
mgoltzsche
force-pushed
the
make_mount_propagation_configurable
branch
from
7049c8e to
6a36c3b
Compare
The helper Pod template's `data` volumeMount is merged with the defaults in order to allow users to specify the `mountPropagation` within the template. Closes rancher#165 Signed-off-by: Max Goltzsche <[email protected]>
mgoltzsche
force-pushed
the
make_mount_propagation_configurable
branch
from
6a36c3b to
0dcef18
Compare
|
Fixed. This is ready for review now. |
|
Can we get this change merged anytime soon? |
Thanks for the notification. I will review it. |
|
Hi @derekbit |
derekbit
reviewed
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper Pod template's
datavolumeMount is merged with the defaults in order to allow users to specify themountPropagationwithin the template.Split from PR #166.
Closes #165.
Relates to #127.