-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the simplest CI with make #10982
Draft
HoloRin
wants to merge
64
commits into
main
Choose a base branch
from
make-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
make-ci
branch
5 times, most recently
from
April 16, 2024 16:04
d137b1a
to
d0686ff
Compare
HoloRin
force-pushed
the
make-ci
branch
8 times, most recently
from
April 24, 2024 13:36
9e90669
to
b3255af
Compare
HoloRin
force-pushed
the
make-ci
branch
8 times, most recently
from
April 29, 2024 16:40
471191b
to
358757c
Compare
HoloRin
force-pushed
the
make-ci
branch
4 times, most recently
from
May 2, 2024 13:35
b9ef746
to
ee5a60f
Compare
So that github actions does not report it as an errored workflow, when it is only a template
so we can see what fails
since the test suite in rabbitmq_prometheus invokes test-build, it ends up wiping out any copies of the module. Links seem to be the most natural workaround, as the module depends on the federation header and therefore can't be easily moved to rabbit_ct_helpers
It turns out that actions workflow artifacts are visible to everyone, so injected credentials would be leaked via the test logs. Therefore we just skip them (they still run in the bazel workflows where the logs are protected).
otherwise it's stale
therefore all dimensions of the matrix must be included in the key, otherwise the first to finish within the matrix, wins
Technically this is a workaround - dialyzer should not be checking the khepri source in this case
Since we apparently hit a workflow size limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check total run time