Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the simplest CI with make #10982

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Add the simplest CI with make #10982

wants to merge 64 commits into from

Commits on May 6, 2024

  1. Add the simplest CI with make

    To check total run time
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    543b4d2 View commit details
    Browse the repository at this point in the history
  2. just deps/rabbit first

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    537e47c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ce0396 View commit details
    Browse the repository at this point in the history
  4. fix summary job

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    85cb326 View commit details
    Browse the repository at this point in the history
  5. Add all the plugins

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8543db8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    593d919 View commit details
    Browse the repository at this point in the history
  7. Add the most basic test result caching

    The github actions cache cannot be modified in parallel, so we copy it
    into a workflow artifact and then merge the artifacts together at the
    end
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b54ed38 View commit details
    Browse the repository at this point in the history
  8. fix artifact name collisions

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2b8a7ef View commit details
    Browse the repository at this point in the history
  9. fix testlogs path

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8d58080 View commit details
    Browse the repository at this point in the history
  10. Fix copy-paste error

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b03fac9 View commit details
    Browse the repository at this point in the history
  11. debug

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    128f10b View commit details
    Browse the repository at this point in the history
  12. debug 2

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1fb622a View commit details
    Browse the repository at this point in the history
  13. debug 3

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f177085 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a363a75 View commit details
    Browse the repository at this point in the history
  15. account for empty cache

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    afdbab6 View commit details
    Browse the repository at this point in the history
  16. split up tests

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0bff86b View commit details
    Browse the repository at this point in the history
  17. more cache fixes

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    83b0585 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    3913587 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    cca39f8 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    ed540c9 View commit details
    Browse the repository at this point in the history
  21. fail-fast false

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bcee6e0 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    22de8b1 View commit details
    Browse the repository at this point in the history
  23. no continue-on-error

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a38618a View commit details
    Browse the repository at this point in the history
  24. Ignore dialyze errors for rabbitmq_ct_helpers & trust_store_http

    in make as we do in bazel
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1044497 View commit details
    Browse the repository at this point in the history
  25. Generate the deps/rabbit workflow with make

    Update with `make -C deps/rabbit
    ../../.github/workflows/test-rabbit.yaml`
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    655a84a View commit details
    Browse the repository at this point in the history
  26. try to fix caching again

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d0517ea View commit details
    Browse the repository at this point in the history
  27. Use a generated workflow for each plugin

    `make actions-workflows` to update
    
    If a new plugin is added, update TESTED_PLUGINS in Makefile and
    test-make.yaml workflow accordingly
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    40c5764 View commit details
    Browse the repository at this point in the history
  28. Also template test-make.yaml

    It turns out github actions won't let you template a matrix value into
    the 'uses' of a job, so we have to template out the file
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    85cbf69 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    48fb2c9 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    946ecfa View commit details
    Browse the repository at this point in the history
  31. install ytt

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    86c833e View commit details
    Browse the repository at this point in the history
  32. fix inputs. references

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4e2b750 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    8eadf14 View commit details
    Browse the repository at this point in the history
  34. update some cache flags

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    45ab6d2 View commit details
    Browse the repository at this point in the history
  35. Handle the fact the github actions cache does not allows updates

    If there is a cache hit, there is never a save. Therefore, we need to
    always miss on the first run attempt, falling back hopefully to the
    previous run.
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4af5294 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    1a4c06d View commit details
    Browse the repository at this point in the history
  37. Try different cache actions

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    058ea27 View commit details
    Browse the repository at this point in the history
  38. again rework caching

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c8b09b4 View commit details
    Browse the repository at this point in the history
  39. debug caching

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6e80eed View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    e398f8b View commit details
    Browse the repository at this point in the history
  41. Cache the initial 'make'

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bec47ae View commit details
    Browse the repository at this point in the history
  42. add missing action param

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    dc30b64 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    a3f468b View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    7936d30 View commit details
    Browse the repository at this point in the history
  45. more cache key fixing

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e135104 View commit details
    Browse the repository at this point in the history
  46. Move test-make.template.yaml

    So that github actions does not report it as an errored workflow, when
    it is only a template
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6654fa3 View commit details
    Browse the repository at this point in the history
  47. Run xref at the project root

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    98b4a8b View commit details
    Browse the repository at this point in the history
  48. Temporarily run the plugin tests in parallel with deps/rabbit

    so we can see what fails
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5c04bc6 View commit details
    Browse the repository at this point in the history
  49. Symlink rabbit_federation_test_util for make

    since the test suite in rabbitmq_prometheus invokes test-build, it
    ends up wiping out any copies of the module. Links seem to be the most
    natural workaround, as the module depends on the federation header and
    therefore can't be easily moved to rabbit_ct_helpers
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7785402 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    62cb16e View commit details
    Browse the repository at this point in the history
  51. Skip the aws integration tests

    It turns out that actions workflow artifacts are visible to everyone,
    so injected credentials would be leaked via the test logs. Therefore
    we just skip them (they still run in the bazel workflows where the
    logs are protected).
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2d77477 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    84b9bb2 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    4ad0bc0 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    6a9880e View commit details
    Browse the repository at this point in the history
  55. Always recompute the previous attempt number

    otherwise it's stale
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    65aed64 View commit details
    Browse the repository at this point in the history
  56. Once again, the actions caches are immutable

    therefore all dimensions of the matrix must be included in the key,
    otherwise the first to finish within the matrix, wins
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1e466dc View commit details
    Browse the repository at this point in the history
  57. Fix dialyze error for deps/rabbit

    Technically this is a workaround - dialyzer should not be checking the
    khepri source in this case
    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    385635a View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    2eb3c6c View commit details
    Browse the repository at this point in the history
  59. regen actions workflows

    HoloRin committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8739458 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    0ded9a7 View commit details
    Browse the repository at this point in the history
  2. Split test-make.yaml

    Since we apparently hit a workflow size limit
    HoloRin committed May 8, 2024
    Configuration menu
    Copy the full SHA
    899bb10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f65ab2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4a66358 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. make mixed templating fixes

    HoloRin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e5159cf View commit details
    Browse the repository at this point in the history