Fix setting default tokens when verbose mode is FALSE and fix checks for GitLab token scopes
#527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed for default token but had verbose switched to FALSE.
…is done already in test_token function call. Therefore, the private method for GitLab has been deleted.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #527 +/- ##
==========================================
- Coverage 75.01% 74.91% -0.11%
==========================================
Files 17 17
Lines 3146 3133 -13
==========================================
- Hits 2360 2347 -13
Misses 786 786 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Oct 29, 2024
marcinkowskak
approved these changes
Oct 29, 2024
maciekbanas
deleted the
525-setting-verbose-to-false-with-non-defined-token-resullts-in-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #525 #526
This PR addresses two issues:
FALSEand