Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking token scopes for GitLab API #526

Closed
Tracked by #528
maciekbanas opened this issue Oct 29, 2024 · 1 comment · Fixed by #527
Closed
Tracked by #528

Fix checking token scopes for GitLab API #526

maciekbanas opened this issue Oct 29, 2024 · 1 comment · Fixed by #527
Assignees
@maciekbanas
Labels
bugfix Something isn't working setup token

Comments

@maciekbanas
Copy link
Member

Method is too vague and not simple. It seems it is unnecessary as, read_api scope for token is met when client can pull the data from the endpoint, e.g. gitlab.com/api/v4/projects - that test is done already in test_token() method. That means, that check_token method for GitLab can be sustained.
@maciekbanas maciekbanas self-assigned this Oct 29, 2024
@maciekbanas maciekbanas added bugfix Something isn't working token setup labels Oct 29, 2024
@maciekbanas
Copy link
Member Author

This issue will be addressed with #525

@maciekbanas maciekbanas mentioned this issue Oct 29, 2024
Merged
@maciekbanas maciekbanas linked a pull request Oct 29, 2024 that will close this issue
Fix setting default tokens when verbose mode is FALSE and fix checks for GitLab token scopes #527
Merged
@maciekbanas maciekbanas mentioned this issue Oct 29, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciekbanas maciekbanas

Labels
bugfix Something isn't working setup token
Projects
None yet
Milestone
No milestone
1 participant
@maciekbanas