array_converter mit Attributen konfigurieren #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHajoha
force-pushed
the
array-converter-attrs
branch
from
d7b8c33 to
e30413d
Compare
tumidi
approved these changes
Oct 24, 2024
larsbonczek
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Du verwendest überall double quotes für Strings. Der Coding Style von Moodle erlaubt das eigentlich nur in Sonderfällen: https://moodledev.io/general/development/policies/codingstyle#strings
MHajoha
force-pushed
the
array-converter-attrs
branch
from
cb9dfaa to
069d7b8
Compare
Cringe. Es passt eigentlich nicht in den PR, aber ich habe es in zwei neuen Commits für das ganze Repo angepasst (danke phpcbf). Kann ich gerne stattdessen auf dev machen, wenn euch das den PR zu sehr zumüllt. |
Moodle prefers single-quoted strings. See: https://moodledev.io/general/development/policies/codingstyle#strings
MHajoha
force-pushed
the
array-converter-attrs
branch
from
069d7b8 to
c87a889
Compare
A dirty hack which applies moodlehq/moodle-local_moodlecheck#148 during CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$config->renamewird ersetzt durch#[array_key(...)]$config->aliaswird ersetzt durch#[array_alias(...)]$config->array_elementswird ersetzt durch#[array_element_class(...)]$config->discriminated_by,$config->variantund$config->fallback_variantwird ersetzt durch#[array_polymorphic(...)]Es wird natürlich einige Konflikte mit 4e273bc geben, die würde ich dann fixen, sobald das gemergt ist.