style: have phpcbf replace string double-quotes with single-quotes

questionpy-org · Oct 28, 2024 · cb9dfaa · cb9dfaa
1 parent d0f1053
commit cb9dfaa
Show file tree

Hide file tree

Showing 72 changed files with 482 additions and 482 deletions.
diff --git a/classes/api/api.php b/classes/api/api.php
@@ -95,7 +95,7 @@ public static function extract_package_info(stored_file $file): package_raw {
             'package' => curl_file_create($filepath),
         ];
 
-        $response = $connector->post("/package-extract-info", $data);
+        $response = $connector->post('/package-extract-info', $data);
         $response->assert_2xx();
         return array_converter::from_array(package_raw::class, $response->get_data());
     }
@@ -107,7 +107,7 @@ public static function extract_package_info(stored_file $file): package_raw {
      */
     public static function get_server_status(): status {
         $connector = connector::default();
-        $response = $connector->get("/status");
+        $response = $connector->get('/status');
         $response->assert_2xx();
         return array_converter::from_array(status::class, $response->get_data());
     }

diff --git a/classes/api/attempt_file.php b/classes/api/attempt_file.php
@@ -31,7 +31,7 @@ class attempt_file {
     public string $name;
 
     /** @var string|null */
-    #[array_key("mime_type")]
+    #[array_key('mime_type')]
     public ?string $mimetype = null;
 
     /** @var string $data */

diff --git a/classes/api/attempt_scored.php b/classes/api/attempt_scored.php
@@ -28,11 +28,11 @@
  */
 class attempt_scored extends attempt {
     /** @var string|null */
-    #[array_key("scoring_state")]
+    #[array_key('scoring_state')]
     public ?string $scoringstate;
 
     /** @var string */
-    #[array_key("scoring_code")]
+    #[array_key('scoring_code')]
     public string $scoringcode;
 
     /** @var float|null */

diff --git a/classes/api/attempt_started.php b/classes/api/attempt_started.php
@@ -28,7 +28,7 @@
  */
 class attempt_started extends attempt {
     /** @var string */
-    #[array_key("attempt_state")]
+    #[array_key('attempt_state')]
     public string $attemptstate;
 
     /**

diff --git a/classes/api/attempt_ui.php b/classes/api/attempt_ui.php
@@ -32,31 +32,31 @@ class attempt_ui {
     public string $formulation;
 
     /** @var string|null */
-    #[array_key("general_feedback")]
+    #[array_key('general_feedback')]
     public ?string $generalfeedback = null;
 
     /** @var string|null */
-    #[array_key("specific_feedback")]
+    #[array_key('specific_feedback')]
     public ?string $specificfeedback = null;
 
     /** @var string|null */
-    #[array_key("right_answer")]
+    #[array_key('right_answer')]
     public ?string $rightanswer = null;
 
     /** @var array<string, string> string to string mapping of placeholder names to the values (to be replaced in the content) */
     public array $placeholders = [];
 
     /** @var string[]|null */
-    #[array_key("css_files")]
+    #[array_key('css_files')]
     public ?array $cssfiles = null;
 
     /** @var array<string, attempt_file> specifics TBD */
     #[array_element_class(attempt_file::class)]
     public array $files = [];
 
     /** @var string specifics TBD */
-    #[array_key("cache_control")]
-    public string $cachecontrol = "PRIVATE_CACHE";
+    #[array_key('cache_control')]
+    public string $cachecontrol = 'PRIVATE_CACHE';
 
     /**
      * Initializes a new instance.

diff --git a/classes/api/package_api.php b/classes/api/package_api.php
@@ -194,17 +194,17 @@ private function guzzle_post_and_maybe_retry(string $uri, array $options = [], b
 
             $fd = $this->file->get_content_file_handle();
             try {
-                $options["multipart"][] = [
-                    "name" => "package",
-                    "contents" => $fd,
+                $options['multipart'][] = [
+                    'name' => 'package',
+                    'contents' => $fd,
                 ];
 
                 return $this->guzzle_post_and_maybe_retry($uri, $options, allowretry: false);
             } finally {
                 @fclose($fd);
             }
         } catch (GuzzleException $e) {
-            throw new coding_exception("Request to QPy server failed: " . $e->getMessage());
+            throw new coding_exception('Request to QPy server failed: ' . $e->getMessage());
         }
     }
 
@@ -226,7 +226,7 @@ public function download_static_file(string $namespace, string $shortname, strin
         try {
             $res = $this->guzzle_post_and_maybe_retry(
                 "/packages/$this->hash/file/$namespace/$shortname/$kind/$path",
-                ["sink" => $targetpath]
+                ['sink' => $targetpath]
             );
         } catch (BadResponseException $e) {
             if ($e->getResponse()->getStatusCode() == 404) {
@@ -239,11 +239,11 @@ public function download_static_file(string $namespace, string $shortname, strin
             );
         }
 
-        if ($res->hasHeader("Content-Type")) {
-            return $res->getHeader("Content-Type")[0];
+        if ($res->hasHeader('Content-Type')) {
+            return $res->getHeader('Content-Type')[0];
         } else {
-            debugging("Server did not send Content-Type header, falling back to application/octet-stream");
-            return "application/octet-stream";
+            debugging('Server did not send Content-Type header, falling back to application/octet-stream');
+            return 'application/octet-stream';
         }
     }
 

diff --git a/classes/api/qpy_http_client.php b/classes/api/qpy_http_client.php
@@ -37,8 +37,8 @@ class qpy_http_client extends http_client {
      * @throws dml_exception
      */
     public function __construct(array $config = []) {
-        $config["base_uri"] = rtrim(get_config('qtype_questionpy', 'server_url'), "/") . "/";
-        $config["timeout"] = get_config('qtype_questionpy', 'server_timeout');
+        $config['base_uri'] = rtrim(get_config('qtype_questionpy', 'server_url'), '/') . '/';
+        $config['timeout'] = get_config('qtype_questionpy', 'server_timeout');
         parent::__construct($config);
     }
 
@@ -53,7 +53,7 @@ protected function get_handlers(array $settings): HandlerStack {
         /* This checks requests against Moodle's curlsecurityblockedhosts, which we don't want, since admins would need
            to ensure their QPy server isn't in this list otherwise. There may be ways to granularly allow the
            server_url, but this will do for now. */
-        $handlerstack->remove("moodle_check_initial_request");
+        $handlerstack->remove('moodle_check_initial_request');
         return $handlerstack;
     }
 }
diff --git a/classes/api/question_edit_form_response.php b/classes/api/question_edit_form_response.php
@@ -32,7 +32,7 @@ class question_edit_form_response {
     public qpy_form $definition;
 
     /** @var array */
-    #[array_key("form_data")]
+    #[array_key('form_data')]
     public array $formdata;
 
     /**

diff --git a/classes/api/question_response.php b/classes/api/question_response.php
@@ -28,34 +28,34 @@
  */
 class question_response {
     /** @var string */
-    #[array_key("question_state")]
+    #[array_key('question_state')]
     public string $state;
 
     /** @var string */
-    #[array_key("scoring_method")]
+    #[array_key('scoring_method')]
     public string $scoringmethod;
 
     /** @var float|int */
-    #[array_key("score_min")]
+    #[array_key('score_min')]
     public float $scoremin = 0;
 
     /** @var float|int */
-    #[array_key("score_max")]
+    #[array_key('score_max')]
     public float $scoremax = 1;
 
     /** @var float|null */
     public ?float $penalty = null;
 
     /** @var float|null */
-    #[array_key("random_guess_score")]
+    #[array_key('random_guess_score')]
     public ?float $randomguessscore = null;
 
     /** @var bool */
-    #[array_key("render_every_view")]
+    #[array_key('render_every_view')]
     public bool $rendereveryview = false;
 
     /** @var string|null */
-    #[array_key("general_feedback")]
+    #[array_key('general_feedback')]
     public ?string $generalfeedback = null;
 
     /**

diff --git a/classes/api/status.php b/classes/api/status.php
@@ -34,11 +34,11 @@ class status {
     public string $version;
 
     /** @var bool */
-    #[array_key("allow_lms_packages")]
+    #[array_key('allow_lms_packages')]
     public bool $allowlmspackages = false;
 
     /** @var string */
-    #[array_key("max_package_size")]
+    #[array_key('max_package_size')]
     public string $maxpackagesize;
 
     /** @var usage|null */

diff --git a/classes/api/usage.php b/classes/api/usage.php
@@ -28,11 +28,11 @@
  */
 class usage {
     /** @var int */
-    #[array_key("requests_in_process")]
+    #[array_key('requests_in_process')]
     public int $requestsinprocess;
 
     /** @var int */
-    #[array_key("requests_in_queue")]
+    #[array_key('requests_in_queue')]
     public int $requestsinqueue;
 
     /**

diff --git a/classes/array_converter/array_converter.php b/classes/array_converter/array_converter.php
@@ -66,9 +66,9 @@ public static function from_array(string $class, array $raw): object {
                 if ($discriminator !== null && $discriminator !== $expected) {
                     // If the wrong discriminator is given, it is an error.
                     throw new moodle_exception(
-                        "cannotgetdata",
-                        "error",
-                        "",
+                        'cannotgetdata',
+                        'error',
+                        '',
                         null,
                         "Expected '$config->discriminator' value '$expected', but got '$discriminator'"
                     );
@@ -83,7 +83,7 @@ public static function from_array(string $class, array $raw): object {
                         debugging($message . " Using fallback variant '$config->fallbackvariant'.");
                         $class = $config->fallbackvariant;
                     } else {
-                        throw new moodle_exception("cannotgetdata", "error", "", null, $message);
+                        throw new moodle_exception('cannotgetdata', 'error', '', null, $message);
                     }
                 }
 
@@ -115,7 +115,7 @@ public static function to_array($instance) {
             return $instance;
         }
         if (is_array($instance)) {
-            return array_map([self::class, "to_array"], $instance);
+            return array_map([self::class, 'to_array'], $instance);
         }
         if (!is_object($instance)) {
             return (array)$instance;
@@ -181,9 +181,9 @@ private static function instantiate(ReflectionClass $reflect, converter_config $
                     $args[] = $parameter->getDefaultValue();
                 } else if (!$parameter->isVariadic()) {
                     throw new moodle_exception(
-                        "cannotgetdata",
-                        "error",
-                        "",
+                        'cannotgetdata',
+                        'error',
+                        '',
                         null,
                         "No value provided for required field '$parameter->name' of '{$reflect->getName()}'"
                     );
@@ -276,7 +276,7 @@ private static function convert_to_required_type(?ReflectionNamedType $type, con
             return $value;
         }
 
-        if ($type->getName() === "array") {
+        if ($type->getName() === 'array') {
             $elementclass = $config->elementclasses[$propname] ?? null;
             if ($elementclass) {
                 // Convert each element to the required class.
@@ -295,9 +295,9 @@ private static function convert_to_required_type(?ReflectionNamedType $type, con
 
         $actualtype = gettype($value);
         throw new moodle_exception(
-            "cannotgetdata",
-            "error",
-            "",
+            'cannotgetdata',
+            'error',
+            '',
             null,
             "Cannot convert value of type '$actualtype' to type '{$type->getName()}'"
         );

diff --git a/classes/external/favourite_package.php b/classes/external/favourite_package.php
@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $CFG;
-require_once($CFG->libdir . "/externallib.php");
+require_once($CFG->libdir . '/externallib.php');
 
 use context;
 use context_system;

diff --git a/classes/external/get_tags.php b/classes/external/get_tags.php
@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $CFG;
-require_once($CFG->libdir . "/externallib.php");
+require_once($CFG->libdir . '/externallib.php');
 
 use context_system;
 use external_api;

diff --git a/classes/external/load_packages.php b/classes/external/load_packages.php
@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $CFG;
-require_once($CFG->libdir . "/externallib.php");
+require_once($CFG->libdir . '/externallib.php');
 
 use core\di;
 use external_api;

diff --git a/classes/external/remove_packages.php b/classes/external/remove_packages.php
@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $CFG;
-require_once($CFG->libdir . "/externallib.php");
+require_once($CFG->libdir . '/externallib.php');
 
 use external_api;
 use external_function_parameters;

diff --git a/classes/external/search_packages.php b/classes/external/search_packages.php
@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die;
 
 global $CFG;
-require_once($CFG->libdir . "/externallib.php");
+require_once($CFG->libdir . '/externallib.php');
 
 use context;
 use context_system;
@@ -92,10 +92,10 @@ private static function validate_parameter_values($params): void {
             throw new invalid_parameter_exception("Unknown order. Valid parameters are: $validparameters");
         }
         if ($params['limit'] <= 0 || $params['limit'] > 100) {
-            throw new invalid_parameter_exception("The limit can only be a value from 1 to 100.");
+            throw new invalid_parameter_exception('The limit can only be a value from 1 to 100.');
         }
         if ($params['page'] < 0) {
-            throw new invalid_parameter_exception("The page can not be negative.");
+            throw new invalid_parameter_exception('The page can not be negative.');
         }
     }
 
@@ -285,10 +285,10 @@ private static function create_best_language_sql(): array {
      */
     private static function create_recently_used_sql(int $contextid): array {
         // Create relevant sql fragment.
-        $joinlastusedsql = "
+        $joinlastusedsql = '
             JOIN {qtype_questionpy_lastused} lu
             ON lu.packageid = p.id AND lu.contextid = :contextid
-        ";
+        ';
 
         return [$joinlastusedsql, ['contextid' => $contextid]];
     }

diff --git a/classes/form/conditions/condition.php b/classes/form/conditions/condition.php
@@ -26,12 +26,12 @@
  * @copyright  2022 TU Berlin, innoCampus {@link https://www.questionpy.org}
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-#[array_polymorphic("kind", variants: [
-    "is_checked" => is_checked::class,
-    "is_not_checked" => is_not_checked::class,
-    "equals" => equals::class,
-    "does_not_equal" => does_not_equal::class,
-    "in" => in::class,
+#[array_polymorphic('kind', variants: [
+    'is_checked' => is_checked::class,
+    'is_not_checked' => is_not_checked::class,
+    'equals' => equals::class,
+    'does_not_equal' => does_not_equal::class,
+    'in' => in::class,
 ])]
 abstract class condition {
     /** @var string $name name of the target element */

diff --git a/classes/form/conditions/does_not_equal.php b/classes/form/conditions/does_not_equal.php
@@ -32,6 +32,6 @@ class does_not_equal extends condition_with_value {
      * @return string
      */
     public static function mform_type(): string {
-        return "neq";
+        return 'neq';
     }
 }