Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HMR for CSS and improve overflow behaviour of bottom panel #214

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Enable HMR for CSS and improve overflow behaviour of bottom panel #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798d505
Add HMR support for CSS
oliver-daniel Oct 30, 2023
4160059
Flexbox is like violence: if it doesn't work, you just need more of it
oliver-daniel Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-console/src/components/Splitter/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export const Splitter = ({
display: "flex",
flexGrow: 0,
flexBasis: basis ?? fallback,
flexShrink: 0,
flexShrink: 1,
}

if (children.length === 1) {
Expand Down
2 changes: 2 additions & 0 deletions packages/web-console/src/scenes/Console/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,14 @@ const Top = styled.div`
const Bottom = styled.div`
display: flex;
flex: 1;
min-height: 0px;
`

const Tab = styled.div`
display: flex;
width: calc(100% - 4.5rem);
height: 100%;
overflow: auto;
`

const viewModes: {
Expand Down
6 changes: 4 additions & 2 deletions packages/web-console/src/scenes/Layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import { Help } from "./help"
const Page = styled.div`
display: flex;
width: 100%;
height: calc(100% - 4rem);
height: 100%;
flex-direction: column;
flex: 1;
overflow: hidden;
Expand All @@ -56,11 +56,13 @@ const Page = styled.div`
const Root = styled.div`
display: flex;
width: 100%;
height: 100%;
flex: 1;
overflow-y: auto;
`

const Main = styled.div<{ sideOpened: boolean }>`
flex: 1;
display: flex;
width: ${({ sideOpened }) =>
sideOpened ? "calc(100% - 50rem - 4.5rem)" : "calc(100% - 4.5rem)"};
`
Expand Down
1 change: 1 addition & 0 deletions packages/web-console/src/styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ ol.unstyled {
/* FOOTER */

#footer {
position: relative;
display: flex;
background: #21222c;
flex: 0 0 4rem;
Expand Down
2 changes: 1 addition & 1 deletion packages/web-console/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ module.exports = {
}),

new MiniCssExtractPlugin({
filename: "[name].[chunkhash:5].css",
filename: config.isProduction ? "[name].[chunkhash:5].css" : "[name].css",
}),

new Webpack.DefinePlugin({
Expand Down
Loading