Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HMR for CSS and improve overflow behaviour of bottom panel #214

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

oliver-daniel
Copy link
Contributor

@oliver-daniel oliver-daniel commented Oct 30, 2023

Before After
Screen Shot 2023-10-30 at 17 24 44 Screen Shot 2023-10-30 at 17 25 01

(viewport height: 330px)

Also harder to show, but the File queue view is now scrollable in both axes on sufficiently small viewports/panel sizes.

The strangest "hack" of these changes is the addition of:

const Bottom = styled.div`
  display: flex;
  flex: 1;
  + min-height: 0px;
`

But, doing so allows each panel of the editor to handle its own resizing strategy in a way that should be appropriate.

@insmac insmac merged commit 399dd71 into web-console/news-ui Oct 30, 2023
1 check failed
@insmac insmac deleted the web-console/flex-overflow branch October 30, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants