rpm: consult dnf database for repository information #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdonnay
force-pushed
the
hack/dnf
branch
2 times, most recently
from
5acce04 to
5a9d76e
Compare
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
- Coverage 55.39% 55.23% -0.17%
==========================================
Files 282 283 +1
Lines 17836 17923 +87
==========================================
+ Hits 9881 9899 +18
- Misses 6923 6990 +67
- Partials 1032 1034 +2 ☔ View full report in Codecov by Sentry. |
hdonnay
changed the title
hdonnay
commented
Dec 19, 2024
rpm/dnf.go
Outdated
Comment on lines
49
to
52
| if fi, err := fs.Stat(sys, `root/buildinfo/content_manifests`); errors.Is(err, nil) && fi.IsDir() { | ||
| // This is a RHEL layer, skip. | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
- Update this to check the files for a marker value and continue if found.
Should look for from_dnf_hint key in the yaml files.
See also: containerbuildsystem/atomic-reactor#2140
This change consults the dnf history database for the repository a package came from, unless the layer has some features that we know means the results will be useless. See-also: quay#809 Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
This makes things easier to reason about and removes the ad-hoc parsing that used to happen. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tk
See-also: #809