Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm et. al.: lints #1205

Merged
merged 5 commits into from
Jan 12, 2024
Merged

rpm et. al.: lints #1205

merged 5 commits into from
Jan 12, 2024

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Jan 12, 2024

Found these commits hanging out on #869, but they're pretty independent.

Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
@hdonnay hdonnay requested a review from a team as a code owner January 12, 2024 16:57
@hdonnay hdonnay requested review from crozzy and removed request for a team January 12, 2024 16:57
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ad15744) 52.54% compared to head (6c4f1b5) 52.56%.

Files Patch % Lines
rhel/ecosystem.go 0.00% 5 Missing ⚠️
rhel/updaterset.go 0.00% 1 Missing ⚠️
rpm/ecosystem.go 0.00% 1 Missing ⚠️
rpm/ndb/ndb.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   52.54%   52.56%   +0.01%     
==========================================
  Files         224      224              
  Lines       17005    17005              
==========================================
+ Hits         8936     8939       +3     
+ Misses       7251     7249       -2     
+ Partials      818      817       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay
Copy link
Member Author

hdonnay commented Jan 12, 2024

/fast-forward

@github-actions github-actions bot merged commit 6c4f1b5 into quay:main Jan 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants