Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate addon package to TypeScript #749

Merged
merged 10 commits into from
Nov 2, 2023
Merged

refactor: migrate addon package to TypeScript #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8fc07fc
Migrate phone-input component to typescript
Oct 2, 2023
321a6bc
Migrate phone input service to typescript
Oct 2, 2023
2678075
Use phone input service types in phone input component
Oct 2, 2023
f481ac6
Migrate initializer to typescript
Oct 2, 2023
14d8065
Add typescript compatibility scenario job
Oct 3, 2023
0c03300
Move typescript compatibility job to lint.yml
Oct 27, 2023
12ac093
Set allowJS to false in addon tsconfig
Oct 27, 2023
19d7a35
Set optional attributes in args type
Oct 27, 2023
d1d1bf0
Rename iti to clearer intlTelInput naming
Oct 27, 2023
dd44bcc
Change _ prefix to private for all attributes
Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,30 @@ jobs:
args: "--frozen-lockfile"
- name: Run Lint
run: pnpm lint

typescript-compatibility:
name: Type checking - ${{ matrix.typescript-scenario }}
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
typescript-scenario:
- [email protected]
- [email protected]
- typescript@next

steps:
- name: Checkout
uses: actions/checkout@v3
- name: Install pnpm
uses: wyvox/action-setup-pnpm@v3
with:
node-version: 16.x
args: "--frozen-lockfile"
- name: Update TS version
run: pnpm add -D ${{ matrix.typescript-scenario }}
working-directory: ember-phone-input
- name: Type checking
run: pnpm lint:types
working-directory: ember-phone-input
1 change: 1 addition & 0 deletions ember-phone-input/babel.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"presets": [["@babel/preset-typescript"]],
"plugins": [
["@babel/plugin-transform-typescript", { "allowDeclareFields": true }],
"@embroider/addon-dev/template-colocation-plugin",
["@babel/plugin-proposal-decorators", { "legacy": true }],
"@babel/plugin-proposal-class-properties"
Expand Down
2 changes: 2 additions & 0 deletions ember-phone-input/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
"@typescript-eslint/eslint-plugin": "6.9.1",
"@typescript-eslint/parser": "6.9.1",
"concurrently": "8.2.2",
"@types/intl-tel-input": "^18.1.2",
m-jovan marked this conversation as resolved.
Show resolved Hide resolved
"@types/rsvp": "^4.0.5",
"ember-source": "5.4.0",
"ember-template-lint": "5.11.2",
"eslint": "8.52.0",
Expand Down
2 changes: 1 addition & 1 deletion ember-phone-input/src/components/phone-input.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
{{did-insert this.onDidInsert}}
{{did-update this.onDidUpdate @country @number}}
{{will-destroy this.onDestroy}}
data-test-loading-iti={{this.isLoadingIti}}
data-test-loading-iti={{this.isLoadingIntlTelInput}}
type={{this.type}}
/>
Loading