Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate addon package to TypeScript #749

Merged
merged 10 commits into from
Nov 2, 2023
Merged

refactor: migrate addon package to TypeScript #749

merged 10 commits into from
Nov 2, 2023

Conversation

m-jovan
Copy link
Contributor

@m-jovan m-jovan commented Oct 2, 2023 •
edited
Loading

This PR migrates ember-phone-input addon files to typescript. This includes component, service and initializer.

@m-jovan m-jovan force-pushed the enable-typescript branch 7 times, most recently from 1b7cd4c to 8d697b3 Compare October 3, 2023 10:59
@m-jovan m-jovan marked this pull request as ready for review October 3, 2023 12:26
@m-jovan m-jovan force-pushed the enable-typescript branch from 0b19f6b to e551916 Compare October 3, 2023 12:47
vscav
vscav reviewed Oct 11, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
ember-phone-input/package.json Show resolved Hide resolved
@vscav
Copy link
Member

vscav commented Oct 11, 2023 •
edited
Loading

I'd suggest to update the allowJs option to an explicit false in the tsconfig, wdyt?

dannycalleri
dannycalleri reviewed Oct 19, 2023
View reviewed changes
ember-phone-input/src/components/phone-input.ts Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/components/phone-input.ts Outdated Show resolved Hide resolved
ember-phone-input/src/instance-initializers/phone-input.ts Show resolved Hide resolved
ember-phone-input/src/services/phone-input.ts Show resolved Hide resolved
@vscav vscav force-pushed the enable-typescript branch from e77347f to b7c957c Compare November 2, 2023 14:52
@vscav vscav force-pushed the enable-typescript branch from b7c957c to dd44bcc Compare November 2, 2023 15:15
@vscav vscav changed the title Migrate components to typescript refactor: migrate addon package to TypeScript Nov 2, 2023
@vscav vscav added the enhancement New feature or request label Nov 2, 2023
vscav
vscav approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@vscav vscav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vscav vscav merged commit a0236da into master Nov 2, 2023
14 checks passed
@vscav vscav deleted the enable-typescript branch November 2, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasgasco nicolasgasco nicolasgasco approved these changes

@dannycalleri dannycalleri dannycalleri left review comments

@vscav vscav vscav approved these changes

Assignees

@m-jovan m-jovan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-jovan @vscav @dannycalleri @nicolasgasco