cppcheck fixes for queued LTR backports branch #59102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2b3be20)
(cherry picked from commit a7829b7)
(cherry picked from commit 6935c02)
(cherry picked from commit 5c5bbf6)
(cherry picked from commit fc82d4c)
(cherry picked from commit 53a19ca)
(cherry picked from commit b92abc9)
(cherry picked from commit 3c2ed21)
(cherry picked from commit ff9eeb8)
(cherry picked from commit dcb7823)
(cherry picked from commit 0fd2191)
(cherry picked from commit 5fc6ceb)
(cherry picked from commit b200765)
(cherry picked from commit 5cfcff1)
which correctly sets all members (cherry picked from commit bec114f)
(cherry picked from commit 4e6fe9b)
(cherry picked from commit b9a3e8c)
(cherry picked from commit afb38d8)
Add TODO for someone to validate later (cherry picked from commit 2251daf)
(cherry picked from commit a8023f8)
(cherry picked from commit 417f94f)
Indeed `QgsAbstractGeometry::operator=()` is already called. This operator calls the `clear()` method which already clears the cache and the existing geometries. (cherry picked from commit 9fed0f1)
Indeed `QgsCurve::operator=()` is already called. As, `QgsCurve` does not override `operator=`, `QgsAbstractGeometry::operator=()` is called. This operator calls the `clear()` method which already clears the cache and the existing curves. (cherry picked from commit 04b1dd7)
Indeed `QgsSurface::operator=()` is already called. As, `QgsSurface` does not override `operator=`, `QgsAbstractGeometry::operator=()` is called. This operator calls the `clear()` method which clears the exterior ring, the interior rings and the cache. (cherry picked from commit e450947)
We had two different(!!!!) implementations for equality operator for QgsPointXY, with different logic (one handled empty points, the other didn't). This compiled only because one was not marked as const. So we'd get a DIFFERENT equality check logic depending on whether or not the first point was const... eeek! Remove the duplicate one, mark the better one as const
|
Unrelated failures |
rouault
approved these changes
Oct 16, 2024
nyalldawson
merged commit 557d229
into
qgis:queued_ltr_backports
26 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get this branch all green again too...
Manual port of #59091