cppcheck fixes for queued LTR backports branch #59102
Commits on Oct 16, 2024
-
Avoid some false-positive cppcheck functionConst warnings
(cherry picked from commit 2b3be20)
-
Rename private method to sensible name
(cherry picked from commit a7829b7)
-
Remove unused legacy pal class
(cherry picked from commit 6935c02)
-
Fix cppcheck 'function can be const' warnings
(cherry picked from commit 5c5bbf6)
-
Avoid some cppcheck false positives
(cherry picked from commit 53a19ca)
-
Fix some (false positive) cppcheck uninitialized variable warnings
(cherry picked from commit b92abc9)
-
Remove duplicate methods defined in subclasses
(cherry picked from commit ff9eeb8)
-
Remove duplicate inherited members
(cherry picked from commit dcb7823)
-
Fix ignored release value warning
(cherry picked from commit 0fd2191)
-
Suppress some duplInheritedMember warnings
(cherry picked from commit 5fc6ceb)
-
Avoid false-positive cppcheck missingMemberCopy warnings
(cherry picked from commit b200765)
-
Remove broken swap methods, replace with standard assignment op
which correctly sets all members (cherry picked from commit bec114f)
-
Fix/suppress more duplInheritedMember warnings
(cherry picked from commit 4e6fe9b)
-
Fix assert with side effects warning
(cherry picked from commit b9a3e8c)
-
Suppress some possibly valid cppcheck copy member warnings
Add TODO for someone to validate later (cherry picked from commit 2251daf)
-
Fix unused return value warning
(cherry picked from commit a8023f8)
-
Suppress more duplInheritedMember warnings
(cherry picked from commit 417f94f)
-
-
-
qgsgeometrycollection: Remove uneeded clearCache call in operator=
Indeed `QgsAbstractGeometry::operator=()` is already called. This operator calls the `clear()` method which already clears the cache and the existing geometries. (cherry picked from commit 9fed0f1)
-
-
qgscompoundcurve: Remove uneeded clearCache call in operator=
Indeed `QgsCurve::operator=()` is already called. As, `QgsCurve` does not override `operator=`, `QgsAbstractGeometry::operator=()` is called. This operator calls the `clear()` method which already clears the cache and the existing curves. (cherry picked from commit 04b1dd7)
-
qgscurvepolygon: Remove uneeded clearCache call in operator=
Indeed `QgsSurface::operator=()` is already called. As, `QgsSurface` does not override `operator=`, `QgsAbstractGeometry::operator=()` is called. This operator calls the `clear()` method which clears the exterior ring, the interior rings and the cache. (cherry picked from commit e450947)
-
Remove duplicate equality operator for QgsPointXY
We had two different(!!!!) implementations for equality operator for QgsPointXY, with different logic (one handled empty points, the other didn't). This compiled only because one was not marked as const. So we'd get a DIFFERENT equality check logic depending on whether or not the first point was const... eeek! Remove the duplicate one, mark the better one as const
-
I'm not 100% sure if the point == mSnapMatch.point() comparison was intended be done using QgsPointXY or QgsPoint objects here! Use QgsPointXY to keep the behavior the same from before the duplicate QgsPointXY == operator was removed...
-
-
-
