Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize command name in fish shell generated completion file #297

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Sanitize command name in fish shell generated completion file #297

merged 3 commits into from
Dec 12, 2022

Commits on Dec 12, 2022

  1. feat: Add option to 'command with space in name' in fixtures 

    * This triggers a bug in 'fish completion' script as described in https://github.com/python-poetry/poetry/issues/5929#issuecomment-1345580021
* Also adapt bash, zsh and fish sample output
    @riton
    riton committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a8b49ef View commit details
    Browse the repository at this point in the history

  2. feat: Adapt fish completion unit test for command with space 

    * Those test should currently fail
* We should escape quotes within command with space to prevent
  ❯ complete -c poetry -A -n '__fish_seen_subcommand_from 'env remove'' -l all -d 'Remove all managed virtual environments associated with the project.'
    complete: too many arguments
    @riton
    riton committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ef10d4f View commit details
    Browse the repository at this point in the history

  3. feat: Sanitize command name for fish shell to escape quotes 

    * Should produce something like
  ❯ complete -c poetry -A -n '__fish_seen_subcommand_from \'env remove\'' -l all -d 'Remove all managed virtual environments associated with the project.'
    @riton
    riton committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    d735127 View commit details
    Browse the repository at this point in the history