Sanitize command name in fish shell generated completion file #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This triggers a bug in 'fish completion' script as described in https://github.com/python-poetry/poetry/issues/5929#issuecomment-1345580021 * Also adapt bash, zsh and fish sample output
* Those test should currently fail
* We should escape quotes within command with space to prevent
❯ complete -c poetry -A -n '__fish_seen_subcommand_from 'env remove'' -l all -d 'Remove all managed virtual environments associated with the project.'
complete: too many arguments
* Should produce something like ❯ complete -c poetry -A -n '__fish_seen_subcommand_from \'env remove\'' -l all -d 'Remove all managed virtual environments associated with the project.'
Secrus
approved these changes
Dec 12, 2022
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
This P.R tries to fix the behavior described in poetry's Fish completions raise errors but still works issue.
Software versions
I'm running
Description of the patch
A
--goodbyeoption was added to thespaced commandin thecleotest suite. Adding this option mimics the problem described in poetry's Fish completions raise errors but still works issue.fishshell fixture was modified to what I consider a valid solution to the problem.Generated
fishcompletion file before and after the patch:before the patch
after the patch
Modified test suite passes successfully.
I've tested this patch to generate the
poetryfishcompletion file and it seems to solve the problem.