Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madrigal updates #13

Merged
merged 9 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ or test files is frequently very useful. Please also list any relevant details
for your test configuration.

- Test A
- Test B

```
Test B
```

## Test Configuration
* Operating system: Hal
Expand All @@ -36,6 +39,7 @@ for your test configuration.
- [ ] Make sure you are merging into the ``develop`` (not ``main``) branch
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have linted the files updated in this pull request
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
# This workflow will install Python dependencies, run tests and lint with a
# variety of Python versions. For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Documentation Check

Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
# This workflow will install Python dependencies, run tests and lint with a
# variety of Python versions. For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Pytest with Flake8

Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/pip_rc_install.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# This workflow will install Python dependencies and the latest RC of pysatNASA from test pypi.
# This test should be manually run before an RC is officially approved and versioned.
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
# This workflow will install Python dependencies and the latest RC of
# PROJECTNAME from test pypi. This test should be manually run before an RC is
# officially approved and versioned. For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Test install of latest RC from pip

Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/pysat_rc.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
# This workflow will install Python dependencies, run tests and lint with a
# variety of Python versions. For more information see:
# https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Test with latest pysat RC

Expand All @@ -11,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
python-version: ["3.10"]

name: Python ${{ matrix.python-version }} on ${{ matrix.os }}
Expand Down
13 changes: 6 additions & 7 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,12 @@ project may be further defined and clarified by project maintainers.
## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at [email protected]
(PACKAGENAME SPECIFIC EMAIL MAY BE USED HERE). The
project team will review and investigate all complaints, and will respond in a
way that it deems appropriate to the circumstances. The project team is
obligated to maintain confidentiality with regard to the reporter of an
incident. Further details of specific enforcement policies may be posted
separately.
reported by contacting the project team at [email protected]. The
(PACKAGENAME SPECIFIC EMAIL MAY BE USED HERE) project team will review and
investigate all complaints, and will respond in a way that it deems appropriate
to the circumstances. The project team is obligated to maintain confidentiality
with regard to the reporter of an incident. Further details of specific
enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
Expand Down
47 changes: 31 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ Contributing
============

Bug reports, feature suggestions, and other contributions are greatly
appreciated! pysat is a community-driven project and welcomes both feedback and
contributions.
appreciated! pysat and (PROJECT NAME) are community-driven projects that
welcome both feedback and contributions.

Come join us on Slack! An invitation to the pysat workspace is available
in the 'About' section of the
Expand All @@ -13,13 +13,27 @@ are generally held fortnightly.
Short version
-------------

* Submit bug reports and feature requests at
* Submit bug reports, feature requests, and questions at
[GitHub](https://github.com/pysat/PACKAGENAME/issues)

* Make pull requests to the ``develop`` branch

Issues
------

Bug reports, questions, and feature requests should all be made as GitHub
Issues. Templates are provided for each type of issue, to help you include
all the necessary information.

Questions
^^^^^^^^^

Not sure how something works? Ask away! The more information you provide, the
easier the question will be to answer. You can also interact with the pysat
developers on our [slack channel](https://pysat.slack.com).

Bug reports
-----------
^^^^^^^^^^^

When [reporting a bug](https://github.com/pysat/PACKAGENAME/issues) please
include:
Expand All @@ -31,12 +45,12 @@ include:
* Detailed steps to reproduce the bug

Feature requests and feedback
-----------------------------
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The best way to send feedback is to file an issue at
[GitHub](https://github.com/pysat/PACKAGENAME/issues).
The best way to send feedback is to file an
[issue](https://github.com/pysat/PACKAGENAME/issues).

If you are proposing a feature:
If you are proposing a new feature or a change in something that already exists:

* Explain in detail how it would work.

Expand Down Expand Up @@ -94,8 +108,8 @@ To set up `PACKAGENAME` for local development:
Note that pysat uses the `flake-docstrings` and `hacking` packages to ensure
standards in docstring formatting.


6. Update/add documentation (in ``docs``), if relevant
6. Update/add documentation (in ``docs``). Even if you don't think it's
relevant, check to see if any existing examples have changed.

7. Add your name to the .zenodo.json file as an author

Expand Down Expand Up @@ -133,11 +147,11 @@ For merging, you should:
4. Ensure that all checks passed (current checks include Github Actions and
Coveralls)

If you don't have all the necessary Python versions available locally or
have trouble building all the testing environments, you can rely on
GitHub Actions to run the tests for each change you add in the pull
request. Because testing here will delay tests by other developers,
please ensure that the code passes all tests on your local system first.
If you don't have all the necessary Python versions available locally or have
trouble building all the testing environments, you can rely on GitHub Actions to
run the tests for each change you add in the pull request. Because testing here
will delay tests by other developers, please ensure that the code passes all
tests on your local system first.


Project Style Guidelines
Expand Down Expand Up @@ -167,7 +181,8 @@ These include:
* All classes should have `__repr__` and `__str__` functions
* Docstrings use `Note` instead of `Notes`
* Try to avoid creating a try/except statement where except passes
* Use setup_method (or setup_class) and teardown_method (or teardown_class) in test classes
* Use setup_method (or setup_class) and teardown_method (or teardown_class) in
test classes
* Use pytest parametrize in test classes when appropriate
* Use pysat testing utilities when appropriate
* Provide testing class methods with informative failure statements and
Expand Down
14 changes: 14 additions & 0 deletions PACKAGENAME/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
"""Core library for PACKAGENAME.

DESCRIPTION.

"""

try:
from importlib import metadata
except ImportError:
import importlib_metadata as metadata

from PACKAGENAME import instruments # noqa F401

__version__ = metadata.version('PACKAGENAME')
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,5 @@ pysat.utils.registry.register('PACKAGENAME.instruments.EX_INST')
inst = pysat.Instrument('EX', 'INST')
```

The package include analysis tools as well. Detailed examples are in the
documentation (LINK TO READTHEDOCS).
The package also includes analysis tools. Detailed examples are in the
[documentation](LINK TO READTHEDOCS).
4 changes: 2 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import os
from pyproject_parser import PyProject
import sys

sys.path.insert(0, os.path.abspath('..'))

# -- Project information - Replace PACKAGENAME, ETC with appropriate package information ---
Expand Down Expand Up @@ -111,8 +112,7 @@
# Theme options are theme-specific and customize the look and feel of a theme
# further. For a list of options available for each theme, see the
# documentation.
#
# html_theme_options = {}
html_theme_options = {'logo_only': True}

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["setuptools >= 38.6", "pip >= 10"]
build-backend = "setuptools.build_meta"

[project]
name = PACKAGENAME
name = "PACKAGENAME"
version = "0.0.1"
description = 'pysat support for DATA OR ANALYSIS'
readme = "README.md"
Expand Down