Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Madrigal updates #13

Merged
merged 9 commits into from
Sep 18, 2023
Merged

Madrigal updates #13

merged 9 commits into from
Sep 18, 2023

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Sep 14, 2023

Description

Partially addresses #3 by incorporating changes based on pysatMadrigal documentation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Changes incorporated here: pysat/pysatMadrigal#95

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • [N/A] Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Fixed wording in code of conduct so that the phrasing makes more sense.
Updated the contributing guidelines to include a more detailed Issues section.
Improved grammer in readme.
Fixed the toml example by adding missing quotation marks.
Added a linting box to the template.
Updated the comments in the test templates.
Added an example init file.
Added logo to the HTML theme options.
Removed duplicate links to the 'GitHub' text.
@aburrell aburrell requested a review from jklenzing September 14, 2023 14:19
@aburrell aburrell mentioned this pull request Sep 14, 2023
10 tasks
@aburrell aburrell merged commit 7e0cd56 into main Sep 18, 2023
@aburrell aburrell deleted the Madrigal_Updates branch September 18, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants