Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blending] OpenCV - SeamlessClone Method #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jpennors
Copy link
Collaborator

@jpennors jpennors commented Apr 20, 2022

This PR :

  • adds a new blending method from openCV : seamlessClone
  • creates an iteration process to test different blending methods

A quick example for seamlessClone :

set_000_0022

@frgfm frgfm added the enhancement New feature or request label Apr 20, 2022
@MateoLostanlen
Copy link
Member

HI @jpennors! Thank you for your PR. Two small things:

  1. In my opinion this error has nothing to do with the function you added but rather with the choice of crop / image size. If this is the case it would be better to open an issue on the subject
  2. When you open a PR it is important that you explain even quickly what you have done which makes the review easier

Copy link
Collaborator Author

@jpennors jpennors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @MateoLostanlen, the PR is still in progress, I should have open a draft one !

@jpennors jpennors changed the title [WIP] Add SeamlessClone Method in ImageBleding [Blending] OpenCV - SeamlessClone Method Apr 20, 2022
@MateoLostanlen
Copy link
Member

HI @jpennors, could be nice to integrate this method, do you still have issues ?

Copy link
Collaborator Author

@jpennors jpennors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MateoLostanlen Same as sky detection with gradient. I still think it's relevant to keep for now

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2 (7b37f52) into main (2f576c4) will decrease coverage by 1.39%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   90.16%   88.77%   -1.40%     
==========================================
  Files           5        5              
  Lines         183      187       +4     
==========================================
+ Hits          165      166       +1     
- Misses         18       21       +3     
Flag Coverage Δ
unittests 88.77% <25.00%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
syntheticdataset/image_blending.py 89.28% <25.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f576c4...7b37f52. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants