Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blending] Multiple testing methods #4

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

jpennors
Copy link
Collaborator

I cherry picked the commit from #2 to be able to merge this functionality as soon as possible.

This PR adds a way to test different types of blending via a dictionary

Copy link
Collaborator Author

@jpennors jpennors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a rule in the repository, not to be able to merge a PR without approval ? I'm able to merge it right now, but I don't think it's the way we want ! 😅
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule#creating-a-branch-protection-rule

@jpennors jpennors added the enhancement New feature or request label Apr 22, 2022
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR !

@MateoLostanlen MateoLostanlen merged commit ef1d3c8 into pyronear:main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants