♻️ refactor the validate_brand method & add new types

[yezz123]

Selected Reviewer: @Kludex

[yezz123]

please review

[Kludex]

Hmmm... Should we think of a more elegant way to register new brands?

[yezz123]

Hmmm... Should we think of a more elegant way to register new brands?

I really tried to think about something that can be used In that case, but this is the best way to refactor it!

what do you think about make in it like external types? or create secondary package support just for types quit like pycountry

[Kludex]

Hmmm... Should we think of a more elegant way to register new brands?

I really tried to think about something that can be used In that case, but this is the best way to refactor it!

what do you think about make in it like external types? or create secondary package support just for types quit like pycountry

Unless there's already a package that handles it, I don't think we should create a separate one for it now. But... Doesn't a package already exist for this?

[yezz123]

@Kludex what do you think shall we support this one: https://github.com/orokusaki/pycard

[hirotasoshu]

@Kludex what do you think shall we support this one: https://github.com/orokusaki/pycard

@yezz123 This package does not appear to be actively updated (last commit in 2017, opened pull request from 2019) and does not support all proposed card brands

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ebc5bb) 100.00% compared to head (177d866) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          688       707   +19     
  Branches       176       179    +3     
=========================================
+ Hits           688       707   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.