Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more card brands to PaymentCardNumber #33

Closed
1 of 8 tasks
hirotasoshu opened this issue May 4, 2023 · 4 comments · Fixed by #56
Closed
1 of 8 tasks

Add more card brands to PaymentCardNumber #33

hirotasoshu opened this issue May 4, 2023 · 4 comments · Fixed by #56
Labels
good first issue Good for newcomers

Comments

@hirotasoshu
Copy link
Contributor

hirotasoshu commented May 4, 2023

@yezz123
Copy link
Collaborator

yezz123 commented May 4, 2023

Sounds Great 👍🏻

It would be great if you open a PR regarding this

@yezz123 yezz123 added the good first issue Good for newcomers label May 4, 2023
@hirotasoshu
Copy link
Contributor Author

@yezz123 I would love to work on it! But wouldn't it be better to create a separate issue for each card brand and use this issue as a tracker? This way we will have small, distinct patches and everyone who also want to contribute will be able to participate

@Kludex
Copy link
Member

Kludex commented Jun 5, 2023

@yezz123 I would love to work on it! But wouldn't it be better to create a separate issue for each card brand and use this issue as a tracker? This way we will have small, distinct patches and everyone who also want to contribute will be able to participate

Let's just track the related PRs here. 👍

@yezz123 yezz123 linked a pull request Jun 5, 2023 that will close this issue
@kkirsche
Copy link

This may be of use to whoever is implementing this when writing tests:

https://developer.paypal.com/api/rest/sandbox/card-testing/#link-creditcardgenerator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants