-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove linter action redundancies #563
Draft
bsavitzky
wants to merge
4,937
commits into
py4dstem:dev
Choose a base branch
from
bsavitzky:linter_actions_fix
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86,338
−4,447
Draft
Changes from all commits
Commits
Show all changes
4937 commits
Select commit
Hold shift + click to select a range
4ea1773
Adding docstrings and more description
cophus de7f036
Black formatting
cophus 971fd4a
move progress update step
sezelt b13c4c8
Merge pull request #3 from cophus/moire
sezelt a2c11f1
adding "sphinx_rtd_theme" to conf.py
alex-rakowski ebf504e
adding sphinx_rtd_theme to setup.py
alex-rakowski 8e0a343
black style conf.py
alex-rakowski ed1aaa8
adding sphinx_rtd_theme to docs requirements.txt
alex-rakowski 3c5c291
removing sphinx_rtd_theme from setup.py
alex-rakowski 7e8a87c
Merge pull request #531 from py4dstem/docs
sezelt 90591b2
Merge pull request #525 from cophus/grain_clustering
sezelt 5db1146
preprocessing dtype bug
smribet 9b9f04a
update CUDA source file location in setup.py
sezelt ba8e4cc
update cupy import try statements
sezelt c5e6ff0
adding tilt to propagators
smribet 7cc0801
single slice crop patterns
smribet cc9b0d7
Fixing merge conflicts
cophus bd9c2c1
Formatting
cophus 0605b39
tv_denoise typo
gvarnavi 3d66ddc
revisting casting inconsistencies
gvarnavi e1c630b
Merge branch 'py4dstem:dev' into dev
alex-rakowski f50eeb0
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
smribet b5da11f
crop pattern option for all classes
smribet 6fa99d1
fix for gpu
smribet f59b122
cleaned up parallax descan
gvarnavi 605bbfa
added support for float upsampling
gvarnavi db44c90
making descan correction the default
gvarnavi 81098e9
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
smribet 7595332
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
smribet 5482298
removing redundant if statement
gvarnavi 33befbb
Merge pull request #532 from sezelt/cudakern_relocate
bsavitzky e5551f0
Merge pull request #533 from sezelt/cp-import
bsavitzky f5afba8
removed separate ctf corrections and other subpixel improvements
gvarnavi 0158662
Merge remote-tracking branch 'origin/dev' into strain_take_2
smribet f8d0c63
bug fix for calibrated strain
smribet 79a3b15
removes unused imports
bsavitzky 567900b
removes unused method args
bsavitzky 008c9f6
fixes scattering_vector bug
bsavitzky 860a45c
added read-write functionality to parralax
gvarnavi 7862cad
adds documentation
bsavitzky 0cc7e09
fixes variance normalization bug
bsavitzky ce58c29
corrects calculate_statistics return behavior
bsavitzky 9849592
adds documentation
bsavitzky e36c5bc
adds documentation
bsavitzky 55bead0
adds documentation
bsavitzky 2c1202e
simplifies + removes unneeded computation
bsavitzky 49db711
adds documentation
bsavitzky e118a69
'dens'->'density'
bsavitzky ae20c78
makes damping origin fluctuations default behaavior
bsavitzky 377ff37
stores S(k),f(k),other intermediate vals
bsavitzky 7cf0cea
Apply suggestions from code review
sezelt aff987d
format with black
sezelt a203a2d
Merge remote-tracking branch 'origin/dev' into moire
sezelt 8b485c0
clean up moire
sezelt c4ba71b
Fix for plotting bug
cophus 6322ce2
restructures return and plotting behavior more flexibly
bsavitzky eae159a
Merge pull request #535 from cophus/dev
bsavitzky 51705d3
Merge remote-tracking branch 'origin/dev' into strain_take_2
smribet 2a57c11
Starting on CTF fitting
cophus 4f5da88
autoformats
bsavitzky 933e34d
Adding more parts of parallax CTF fitting
cophus d96551e
added chroma_boost for show_complex
gvarnavi 651f4f8
adds placeholder for citations
bsavitzky 1e45c19
Working on CTF
cophus 254dc30
It works!
cophus 0c38b45
Updating outputs
cophus 8f790d0
Adding outputs, plotting
cophus a0e78f2
Merge pull request #536 from cophus/phase_contrast
gvarnavi 2a7a662
finally works
gvarnavi 169df56
some support for aberration correct
gvarnavi d2a0bdb
small bug fixes
gvarnavi 7467bb7
cleaned up parallax
gvarnavi 74ec5b5
ptycho new aberration formalism
gvarnavi f670d0d
adding chroma_boost defaults
gvarnavi 874fa3c
formatted, linted, isorted
gvarnavi c16105e
fixed some manual conflicts
gvarnavi f894823
fixing radial order accounting
gvarnavi 9653925
make lint happy I hope!
smribet 61c21f3
fix extent for ms depth sectioning
smribet 288b9d5
small fixes
smribet 31c3f6c
fix for ptycho aberration fit
smribet ff2a6b2
black format
smribet ff5a7d9
fixed ptycho fitting, added transpose flag in parallax
gvarnavi bd9158a
versions emdfile
bsavitzky 73c14e0
Merge pull request #541 from bsavitzky/array_repr_bugfix
bsavitzky bf8b026
added force_transpose option for other two aberration fit methods
gvarnavi 1d0438b
read-write device bugfix
gvarnavi bf6ee23
Merge pull request #539 from py4dstem/phase_contrast
smribet da57802
Merge pull request #514 from sezelt/moire
sezelt f2e65fc
bugfix to update_version.py
bsavitzky dc20c8f
Manually update version.py
bsavitzky 958813e
Merge pull request #542 from py4dstem/dev
bsavitzky b4a0c17
Merge branch 'dev' into strain_take_2
bsavitzky d8a1c91
bugfix
bsavitzky 60de60d
rms import *
bsavitzky 0a0d9b9
bugfixes to strainmapping
bsavitzky 7b992fb
strain map updates
bsavitzky d171760
add pyright to gitignore
sezelt 97e6ea7
autoformats
bsavitzky 37f107e
Merge pull request #543 from sezelt/dev
bsavitzky 9fa9726
autoformats
bsavitzky bef8d3a
rms deprecated latticevectors module
bsavitzky 36b48cc
rms deprecated latticevectors module
bsavitzky fa5c49a
Merge pull request #500 from cophus/polardata
bsavitzky 4cc671d
Merge pull request #522 from smribet/strain_take_2
bsavitzky 230032d
versions to 0.14.6
bsavitzky c998212
Merge pull request #544 from py4dstem/dev
bsavitzky deccb3e
change default figsize
bsavitzky ac0b656
versions to 0.14.7
bsavitzky 0b2d9fc
Merge pull request #545 from py4dstem/dev
bsavitzky 72653d4
ellipse display bugfix
bsavitzky d4d7d6b
versions to 0.14.8
bsavitzky 334cbd2
autoformats
bsavitzky fcb3bcb
silly parallax bug
gvarnavi cf7b922
some helpful deets
smribet 0f55926
adds QR_rotation vis method
bsavitzky b82e505
adds QR_rot in rad and degrees in Calibration
bsavitzky 3b62bba
adds QR_rot in rad and degrees in Calibration
bsavitzky fe46cad
middle focus for multislice
smribet 3e53b17
Fixing scale bar being plotted as slightly too long
cophus 14cbab1
Add option to skip calculating correlation array in crystal.orientati…
cophus a4890f7
Black formatting
cophus 4df79d5
adding assert statement
alex-rakowski c7540b1
black
alex-rakowski d9de182
re-introducing probe intensity normalizations into constraints
gvarnavi 9295032
Merge branch 'phase_contrast' of github.com:py4dstem/py4DSTEM into ph…
gvarnavi c2a9b61
origin plotting and strain legend updates
bsavitzky 81217fa
updates
bsavitzky 5856edb
bug in depth plotting
smribet 5b780b4
changing assert to warning
alex-rakowski f964d4b
black
alex-rakowski 610a4e6
adds show_reference_directions
bsavitzky e2155a4
change Warning to ValueError
sezelt 451f268
minor dpc bugfixes
gvarnavi accab18
parallax DF limit bug, cropped property
gvarnavi d9146f1
complex grid scalebar bug
gvarnavi ddb4429
updates
bsavitzky 26fb99b
updates
bsavitzky ff897ab
Merge pull request #547 from cophus/dev
alex-rakowski c4b7482
Merge remote-tracking branch 'origin/dev' into phase_contrast
smribet 8d99cc6
updates
bsavitzky 246f7e9
Merge remote-tracking branch 'truth/dev' into morestrain
bsavitzky 4afcedd
autoformats
bsavitzky 89306db
bugfix
bsavitzky 88de378
autoformats
bsavitzky 5e8bb67
adding self_consistency_errors property. not implemented for 3D yet
gvarnavi f92f627
add robustness back to fit_origin
sezelt 9d46c85
Merge remote-tracking branch 'origin/dev' into dev
sezelt 2b6c6e7
add fit function option back
sezelt aac3a8c
Merge pull request #552 from sezelt/robust-fix
bsavitzky dc4d5cf
Merge remote-tracking branch 'origin/dev' into phase_contrast
smribet ac2d04a
real space mask for positions to ignore
smribet 2bae946
amplitudes update for real space mask
smribet 5f6aef1
Thnks fr th Mmr(s)
smribet 1de5369
one more bug
smribet 33d1c49
black format
smribet 454bf56
colorbars for fit origin
smribet 5de6c43
I've been plotting to update this function
smribet 6920c5b
correct propagation of arguments
smribet 21d0fc2
one more bug fix
smribet f51e68b
fft hanning window
smribet 7c6708a
mostly formatting changes
smribet ea5bb36
small bug fixes
smribet e54aab4
ctf transpose bugfix - tested mostly for stig
gvarnavi db1ac20
making ptycho aberration fitting convention consistent
gvarnavi afc93a6
Merge branch 'phase_contrast' of github.com:py4dstem/py4DSTEM into ph…
gvarnavi 5cb3857
adding to_strainmap method
alex-rakowski 116b766
initial namespace chages
alex-rakowski e8a5f7e
update uncertainty viz
gvarnavi f337ef5
generalizing to accommodate other classes easier
gvarnavi 844f9c7
add uncertainty viz to all classes except OT
gvarnavi 8029e64
small kde parallax bug
gvarnavi e351441
more parallax plotting fun(ctionality)
smribet 37e263a
black formatting
smribet bd2e63f
Merge pull request #550 from py4dstem/phase_contrast
smribet 26de989
read/write for masked datasets
smribet c9335f3
Merge pull request #551 from bsavitzky/morestrain
bsavitzky 571a061
Merge remote-tracking branch 'origin/dev' into phase_contrast
smribet e15c344
Merge branch 'dev' into namespace
alex-rakowski 7b4fdb6
Merge pull request #555 from py4dstem/phase_contrast
gvarnavi d153b55
braggvector_copy calstate
smribet 736add5
Merge remote-tracking branch 'origin/dev' into braggvectors
smribet dd560a7
Merge pull request #556 from smribet/braggvectors
bsavitzky fbf6506
pep 8 - Comparisons to singletons complience
alex-rakowski 8e15aa2
== None to is None
alex-rakowski 5672887
black
alex-rakowski 8cf3b36
removing unused f-strings
alex-rakowski 624cb10
changing is Bool to == Bool
alex-rakowski e1cc319
black
alex-rakowski 571cbf3
versions to 0.14.9
bsavitzky c8578dd
bumping to allow 3.12
alex-rakowski 3d2e3a2
updating install checkers to 3.12
alex-rakowski c8fb6bf
nudging quick install to include 3.12
alex-rakowski c2daa73
changing lower bound to 3.9
alex-rakowski 8c12032
correcting syntax error
alex-rakowski bff2b27
fixing DeprecationWarning
alex-rakowski c4909dd
Merge pull request #562 from alex-rakowski/distance_transform_edt_fix
bsavitzky d6fc7fd
changing to assignment
alex-rakowski a97c568
p4DSTEM.phase/classification style
alex-rakowski a24ef46
black
alex-rakowski 590179e
adding orientation
alex-rakowski a5f5d95
rename linter actions
bsavitzky 3956ea3
Merge pull request #558 from alex-rakowski/singletons
bsavitzky bc969e3
removing comments
alex-rakowski b20f113
Merge pull request #561 from alex-rakowski/python-312
bsavitzky a565331
Merge pull request #554 from alex-rakowski/namespace
bsavitzky b4a0ce6
fixing is to ==
alex-rakowski 7f01584
Merge pull request #565 from alex-rakowski/mask_hotpatch
bsavitzky af94ba6
removes redundant linting action
bsavitzky 894b17e
adding E501 to expect fail
alex-rakowski 88b8b35
moving .flake8 file
alex-rakowski 6cc746e
changing : to =
alex-rakowski 563d7fe
updating flake8
alex-rakowski c628ecc
updating flake8
alex-rakowski 7b143b6
updating flake8
alex-rakowski 9c18dea
removing E501 expecting pass
alex-rakowski 4529d98
adding as string with E501 expecting fail
alex-rakowski 742aca8
adding as non string without E501 expecting pass
alex-rakowski 403b4c6
adding some configs expecting fails
alex-rakowski 5f51ed4
removing 501 expecting pass
alex-rakowski 9368425
adding dummy test and E501 expecting pass
alex-rakowski 2de028a
altering dummy and seeing if top level flake works
alex-rakowski 76748d9
clearning up last commit
alex-rakowski e67c59c
moving .flake8 back to .github
alex-rakowski 086b96a
changing to *test/*
alex-rakowski ffdfd4b
changing to **test/*
alex-rakowski 149cb33
changing to test
alex-rakowski d1fd32e
updating to v5
alex-rakowski d197339
changing to test_
alex-rakowski 1428d8e
begins fix for flake8 config
bsavitzky 8405d72
adding new line to test_dummy
alex-rakowski a2b70c3
adding new line to test_dummy
alex-rakowski 8f0487f
filtering to search py4DSTEM only
alex-rakowski 74efd85
trying to add new path to flake file
alex-rakowski 04b52dd
adding ignore __init__.py
alex-rakowski a32886d
updating .flake8 rules
alex-rakowski 6edb932
updating excluding + comments
alex-rakowski a271817
updating and adding comments
alex-rakowski bacbccb
removing dummy test file
alex-rakowski 886f581
removing file
alex-rakowski 4458c70
fixes flake options syntax
bsavitzky 0c1eff2
fixes flake options syntax
bsavitzky 93065b1
conflict errors
alex-rakowski 7e08cb7
moves .flake9 config
bsavitzky 6a86b32
merges dev
bsavitzky 8b7f9a0
Merge pull request #3 from alex-rakowski/linters_test
bsavitzky 272a3f5
update flake config
bsavitzky 18a947c
flake fixes
bsavitzky cccc6b9
flake fixes
bsavitzky fc82d46
autoformats
bsavitzky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
// README at: https://github.com/devcontainers/templates/tree/main/src/miniconda | ||
{ | ||
"name": "py4dstem-dev", | ||
"image": "mcr.microsoft.com/vscode/devcontainers/miniconda:0-3", | ||
// "build": { | ||
// "context": "..", | ||
// "dockerfile": "Dockerfile" | ||
// }, | ||
|
||
// Features to add to the dev container. More info: https://containers.dev/features. | ||
// "features": {}, | ||
|
||
// Use 'forwardPorts' to make a list of ports inside the container available locally. | ||
// "forwardPorts": [] | ||
|
||
// Use 'postCreateCommand' to run commands after the container is created. | ||
"postCreateCommand": "/opt/conda/bin/conda init && /opt/conda/bin/pip install -e /workspaces/py4DSTEM/ && /opt/conda/bin/pip install ipython ipykernel jupyter", | ||
|
||
// Configure tool-specific properties. | ||
"customizations": { | ||
"vscode": { | ||
"settings": { | ||
"python.defaultInterpreterPath": "/opt/conda/bin/python", | ||
"python.analysis.autoFormatStrings": true, | ||
"python.analysis.completeFunctionParens": true, | ||
"ruff.showNotifications": "onWarning", | ||
"workbench.colorTheme": "Monokai", | ||
// "editor.defaultFormatter": "ms-python.black-formatter", | ||
"editor.fontFamily": "Menlo, Monaco, 'Courier New', monospace", | ||
"editor.bracketPairColorization.enabled": true, | ||
"editor.guides.bracketPairs": "active", | ||
"editor.minimap.renderCharacters": false, | ||
"editor.minimap.autohide": true, | ||
"editor.minimap.scale": 2, | ||
"[python]": { | ||
"editor.defaultFormatter": "ms-python.black-formatter", | ||
"editor.codeActionsOnSave": { | ||
"source.organizeImports": false | ||
} | ||
} | ||
}, | ||
"extensions": [ | ||
"ms-python.python", | ||
"donjayamanne.python-extension-pack", | ||
"ms-python.vscode-pylance", | ||
"ms-toolsai.jupyter", | ||
"GitHub.codespaces", | ||
"ms-azuretools.vscode-docker", | ||
"DavidAnson.vscode-markdownlint", | ||
"ms-vsliveshare.vsliveshare", | ||
"charliermarsh.ruff", | ||
"eamodio.gitlens", | ||
"ms-python.black-formatter" | ||
] | ||
} | ||
} | ||
|
||
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root. | ||
// "remoteUser": "root" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
[flake8] | ||
extend-ignore: | ||
E114, | ||
E115, | ||
E116, | ||
E201, | ||
E202, | ||
E203, | ||
E204, | ||
E231, | ||
E265, | ||
E266, | ||
E303, | ||
E402, | ||
E501, | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is, | ||
|
||
**To Reproduce** | ||
Steps to reproduce the behavior, please be as general as possible, and ideally recreate a minimal reproducible example: | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
|
||
**py4DSTEM version** | ||
It can be accessed by running `py4DSTEM.__version__` | ||
**Python version** | ||
It can be accessed using `sys.version` | ||
**Operating system** | ||
Windows, Mac (Intel or ARM), Linux (Distro) | ||
|
||
**GPU** | ||
If GPU related please provide: | ||
- CUDA driver - It can be accessed by: `nvidia-smi` | ||
- Cupy Version - It can be accessed by `cupy.__version__` | ||
|
||
**Screenshots** | ||
If applicable, could you add screenshots to help explain your problem? | ||
|
||
|
||
**Additional context** | ||
Please feel free to add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
""" | ||
Script to update the patch version number of the py4DSTEM package. | ||
""" | ||
|
||
version_file_path = "py4DSTEM/version.py" | ||
|
||
with open(version_file_path, "r") as f: | ||
lines = f.readlines() | ||
|
||
line_split = lines[0].split(".") | ||
patch_number = line_split[2].split("'")[0].split('"')[0] | ||
|
||
# Increment patch number | ||
patch_number = str(int(patch_number) + 1) + "'" | ||
|
||
|
||
new_line = line_split[0] + "." + line_split[1] + "." + patch_number | ||
|
||
with open(version_file_path, "w") as f: | ||
f.write(new_line) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
name: Check code style | ||
|
||
on: | ||
push: | ||
branches: [ "dev" ] | ||
pull_request: | ||
branches: [ "dev" ] | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: psf/black@stable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Install Checker Dev | ||
on: | ||
push: | ||
branches: [ "dev" ] | ||
pull_request: | ||
branches: [ "dev" ] | ||
jobs: | ||
|
||
test-python-os-versions: | ||
name: Check Python ${{ matrix.python-version }} on ${{ matrix.runs-on }} on ${{ matrix.architecture }} | ||
continue-on-error: ${{ matrix.allow_failure }} | ||
runs-on: ${{ matrix.runs-on }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
allow_failure: [false] | ||
runs-on: [ubuntu-latest] | ||
architecture: [x86_64] | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
# include: | ||
# - python-version: "3.12.0-beta.4" | ||
# runs-on: ubuntu-latest | ||
# allow_failure: true | ||
# Currently no public runners available for this but this or arm64 should work next time | ||
# include: | ||
# - python-version: "3.10" | ||
# architecture: [aarch64] | ||
# runs-on: macos-latest | ||
# allow_failure: true | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install repo | ||
run: | | ||
python -m pip install . | ||
- name: Check installation | ||
run: | | ||
python -c "import py4DSTEM; print(py4DSTEM.__version__)" | ||
# - name: Check machine arch | ||
# run: | | ||
# python -c "import platform; print(platform.machine())" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Install Checker Main | ||
on: | ||
push: | ||
branches: [ "main" ] | ||
pull_request: | ||
branches: [ "main" ] | ||
jobs: | ||
|
||
test-python-os-versions: | ||
name: Check Python ${{ matrix.python-version }} on ${{ matrix.runs-on }} on ${{ matrix.architecture }} | ||
continue-on-error: ${{ matrix.allow_failure }} | ||
runs-on: ${{ matrix.runs-on }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
allow_failure: [false] | ||
runs-on: [ubuntu-latest, windows-latest, macos-latest] | ||
architecture: [x86_64] | ||
python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
#include: | ||
# - python-version: "3.12.0-beta.4" | ||
# runs-on: ubuntu-latest | ||
# allow_failure: true | ||
# Currently no public runners available for this but this or arm64 should work next time | ||
# include: | ||
# - python-version: "3.10" | ||
# architecture: [aarch64] | ||
# runs-on: macos-latest | ||
# allow_failure: true | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install repo | ||
run: | | ||
python -m pip install . | ||
- name: Check installation | ||
run: | | ||
python -c "import py4DSTEM; print(py4DSTEM.__version__)" | ||
- name: Check machine arch | ||
run: | | ||
python -c "import platform; print(platform.machine())" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Install Checker Quick | ||
on: | ||
push: | ||
branches-ignore: | ||
- main | ||
- dev | ||
pull_request: | ||
branches-ignore: | ||
- main | ||
- dev | ||
jobs: | ||
|
||
test-python-os-versions: | ||
name: Check Python ${{ matrix.python-version }} on ${{ matrix.runs-on }} on ${{ matrix.architecture }} | ||
continue-on-error: ${{ matrix.allow_failure }} | ||
runs-on: ${{ matrix.runs-on }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
allow_failure: [false] | ||
runs-on: [ubuntu-latest] | ||
architecture: [x86_64] | ||
python-version: ["3.9", "3.12"] | ||
# Currently no public runners available for this but this or arm64 should work next time | ||
# include: | ||
# - python-version: "3.10" | ||
# architecture: [aarch64] | ||
# runs-on: macos-latest | ||
# allow_failure: true | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install repo | ||
run: | | ||
python -m pip install . | ||
- name: Check installation | ||
run: | | ||
python -c "import py4DSTEM; print(py4DSTEM.__version__)" | ||
# - name: Check machine arch | ||
# run: | | ||
# python -c "import platform; print(platform.machine())" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Lint with super-linter@v5-slim | ||
|
||
on: | ||
push: | ||
branches: [ "dev" ] | ||
pull_request: | ||
branches: [ "dev" ] | ||
|
||
jobs: | ||
run-lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
with: | ||
# Full git history is needed to get a proper list of changed files within `super-linter` | ||
fetch-depth: 0 | ||
|
||
- name: Lint Code Base | ||
uses: super-linter/super-linter/slim@v5 # updated to latest slim as quicker to download | ||
env: | ||
VALIDATE_ALL_CODEBASE: false # only check changes | ||
VALIDATE_PYTHON_FLAKE8: true # lint with flake8 | ||
DEFAULT_BRANCH: "dev" # set default branch to dev | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # for github things | ||
# FILTER_REGEX_EXCLUDE: .*test/.* # exclude test dirs | ||
FILTER_REGEX_EXCLUDE: .*__init__.py/.* # exclude test dirs | ||
FILTER_REGEX_INCLUDE: .*py4DSTEM/.* # only look for py4DSTEM | ||
LINTER_RULES_PATH: / # set toplevel dir as the path to look for rules | ||
PYTHON_FLAKE8_CONFIG_FILE: .flake8 # set specific config file |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add, locally collects files differently to the GA
to make it ignore
__init__.py
andsetup.py
files and to stop it searching docs, when run locally, we can also add to tests it to ignore this as well