Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove linter action redundancies #563

Draft
wants to merge 4,937 commits into
base: dev
Choose a base branch
from
Draft

Remove linter action redundancies #563

wants to merge 4,937 commits into from

Conversation

bsavitzky
Copy link
Member

Remove redundancies and fix opaque naming conventions in linter actions

cophus and others added 30 commits October 4, 2023 14:20
@cophus
Adding docstrings and more description
4ea1773 
Former-commit-id: 466343b
@cophus
Black formatting
de7f036 
Former-commit-id: 4f97b81
@sezelt
move progress update step
971fd4a 
Former-commit-id: a48093f
@sezelt
Merge pull request #3 from cophus/moire
b13c4c8 
Adding requested docstrings

Former-commit-id: e21541a
@alex-rakowski
adding "sphinx_rtd_theme" to conf.py
a2c11f1 
Former-commit-id: b067fc1
@alex-rakowski
adding sphinx_rtd_theme to setup.py
ebf504e 
Former-commit-id: 3096f6c
@alex-rakowski
black style conf.py
8e0a343 
Former-commit-id: d7ac9e1
@alex-rakowski
adding sphinx_rtd_theme to docs requirements.txt
ed1aaa8 
Former-commit-id: b19d173
@alex-rakowski
removing sphinx_rtd_theme from setup.py
3c5c291 
Former-commit-id: e07dddd
@sezelt
Merge pull request py4dstem#531 from py4dstem/docs
7e8a87c 
adding "sphinx_rtd_theme" to conf.py

Former-commit-id: 69df1a4
@sezelt
Merge pull request py4dstem#525 from cophus/grain_clustering
90591b2 
Adding grain clustering for ACOM

Former-commit-id: b35d8ec
@smribet
preprocessing dtype bug
5db1146 
Former-commit-id: f2c21d5
@sezelt
update CUDA source file location in setup.py
9b9f04a 
Former-commit-id: d6f4799
@sezelt
update cupy import try statements
ba8e4cc 
Former-commit-id: 74c60d4
@smribet
adding tilt to propagators
c5e6ff0 
Former-commit-id: 7c3a0d8
@smribet
single slice crop patterns
7cc0801 
Former-commit-id: 23204aa
@cophus
Fixing merge conflicts
cc9b0d7 
Former-commit-id: af9f526
@cophus
Formatting
bd9c2c1 
Former-commit-id: 871e0a5
@gvarnavi
tv_denoise typo
0605b39 
Former-commit-id: 84a2067
@gvarnavi
revisting casting inconsistencies
3d66ddc 
Former-commit-id: 0978c4b
@alex-rakowski
Merge branch 'py4dstem:dev' into dev
e1c630b 
Former-commit-id: f20fab2
@smribet
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
f50eeb0 
Former-commit-id: 41069fd
@smribet
crop pattern option for all classes
b5da11f 
Former-commit-id: c9ac5db
@smribet
fix for gpu
6fa99d1 
Former-commit-id: 00991c9
@gvarnavi
cleaned up parallax descan
f59b122 
Former-commit-id: 31af429
@gvarnavi
added support for float upsampling
605bbfa 
Former-commit-id: 43289e3
@gvarnavi
making descan correction the default
db44c90 
Former-commit-id: 35d076f
@smribet
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
81098e9 
Former-commit-id: d2a198e
@smribet
Merge remote-tracking branch 'origin/phase_contrast' into phase_contrast
7595332 
Former-commit-id: 2e25fe1
@gvarnavi
removing redundant if statement
5482298 
Former-commit-id: c06ca46
alex-rakowski and others added 5 commits November 14, 2023 13:40
@alex-rakowski
changing to **test/*
ffdfd4b 
Former-commit-id: 44c3dd5
@alex-rakowski
changing to test
149cb33 
Former-commit-id: 856b645
@alex-rakowski
updating to v5
d1fd32e 
Former-commit-id: 9443afa
@alex-rakowski
changing to test_
d197339 
Former-commit-id: be9d0c6
@bsavitzky
begins fix for flake8 config
1428d8e 
Former-commit-id: 7bb51a7
@mlhenderson
Copy link
Contributor

Expect a bunch of linter errors after the config is resolved that will need to be sorted out in this PR.

@alex-rakowski
Copy link
Collaborator

@bsavitzky these are my suggested changes for the linter

bsavitzky and others added 10 commits November 15, 2023 12:03
@bsavitzky
fixes flake options syntax
4458c70 
Former-commit-id: 497b7d2
@bsavitzky
fixes flake options syntax
0c1eff2 
Former-commit-id: 06f3a43
@alex-rakowski
conflict errors
93065b1 
Former-commit-id: b217814
@bsavitzky
moves .flake9 config
7e08cb7 
Former-commit-id: ac9c0d1
@bsavitzky
merges dev
6a86b32 
Former-commit-id: 2e0ea9c
@bsavitzky
Merge pull request #3 from alex-rakowski/linters_test
8b7f9a0 
my suggest GA linters actions

Former-commit-id: 18ddf65
@bsavitzky
update flake config
272a3f5 
Former-commit-id: 8ec50ad
@bsavitzky
flake fixes
18a947c 
Former-commit-id: e59bf62
@bsavitzky
flake fixes
cccc6b9 
Former-commit-id: cbbb6a6
@bsavitzky
autoformats
fc82d46 
Former-commit-id: 08240da
alex-rakowski
alex-rakowski reviewed Nov 15, 2023
View reviewed changes
.flake8
E266,
E303,
E402,
E501,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add, locally collects files differently to the GA
to make it ignore __init__.py and setup.py files and to stop it searching docs, when run locally, we can also add to tests it to ignore this as well

exclude =
    *__init__.py
    *setup.py
    docs

@sezelt sezelt mentioned this pull request Nov 17, 2023
Closed
@bsavitzky bsavitzky force-pushed the linter_actions_fix branch from 08240da to fc82d46 Compare March 12, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-rakowski alex-rakowski alex-rakowski left review comments

@sezelt sezelt Awaiting requested review from sezelt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bsavitzky @mlhenderson @alex-rakowski @cophus @sezelt @smribet @gvarnavi