Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors, incorrect docblocks #395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix type errors, incorrect docblocks #395

wants to merge 2 commits into from

Commits on Oct 31, 2024

  1. Correct docblock types, params 

    There were some oversights made here when types were added to these
method signatures. The method signatures in question are stricter than
the docblock-hinted types, so the extra docblock types have been
removed to match the enforced method signatures.

One docblock looks like it was copy-pasted from a different function
with a completely different method signature, so the param list in the
docblock has been corrected.

The docblock hint for Pusher::$client hadn't been updated since curl was
replaced with Guzzle as the HTTP client of choice.
    @braindawg
    braindawg committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0c5fee7 View commit details
    Browse the repository at this point in the history

  2. Fix type errors in log calls 

    Looks like these calls to Pusher::log() didn't get updated after pusher#305
changed the method signature to require an array in the second param.
    @braindawg
    braindawg committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6541ecb View commit details
    Browse the repository at this point in the history