Fix type errors, incorrect docblocks #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some oversights made here when types were added to these method signatures. The method signatures in question are stricter than the docblock-hinted types, so the extra docblock types have been removed to match the enforced method signatures. One docblock looks like it was copy-pasted from a different function with a completely different method signature, so the param list in the docblock has been corrected. The docblock hint for Pusher::$client hadn't been updated since curl was replaced with Guzzle as the HTTP client of choice.
Looks like these calls to Pusher::log() didn't get updated after pusher#305 changed the method signature to require an array in the second param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some typing issues that Psalm caught. Calls to
Pusher::log()with a disallowednullparam, a docblock with the wrong method signatures, and several docblocks that have not been updated to match the now stricter types of their method signatures or class properties.There should be no behavioral changes except that the
logfunction calls will no longer trigger TypeErrors.CHANGELOG